From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1KGs1K-0003S7-KN for kexec@lists.infradead.org; Thu, 10 Jul 2008 09:00:58 +0000 Received: from Relay2.suse.de (relay-ext.suse.de [195.135.221.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id 7C1D945803 for ; Thu, 10 Jul 2008 11:00:57 +0200 (CEST) Date: Thu, 10 Jul 2008 11:01:38 +0200 From: Bernhard Walle Subject: Re: [PATCH] makedumpfile: Improve error handing when SIZE(nodemask_t) is undefined Message-ID: <20080710110138.285aa546@halley.suse.de> In-Reply-To: <4875CF72.9060306@mxs.nes.nec.co.jp> References: <20080709134801.149fbdb4@halley.suse.de> <487562F0.8020606@mxs.nes.nec.co.jp> <20080710105157.2af29b21@halley.suse.de> <4875CF72.9060306@mxs.nes.nec.co.jp> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: kexec@lists.infradead.org * Ken'ichi Ohmichi [2008-07-10 17:59]: > Bernhard Walle wrote: > > * Ken'ichi Ohmichi [2008-07-10 10:16]: > >>> + if (SIZE(nodemask_t) == NOT_FOUND_LONG_VALUE) { > >>> + ERRMSG("SIZE(nodemask_t) undefined.\n"); > >> I like the following message of the same form as another message. > >> > >> ERRMSG("Can't get the size of nodemask_t.\n"); > > > > Sounds fine, thanks. > > Thank you for the response. > I merged this patch into DEVEL tree, and I'll merge it into > the next release too. Any plans when you make the next release? Bernhard -- Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec