From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays
Date: Thu, 10 Jul 2008 17:46:19 -0700 [thread overview]
Message-ID: <20080711004619.GJ11809@mail.oracle.com> (raw)
In-Reply-To: <20080711003113.GE32459@wotan.suse.de>
On Thu, Jul 10, 2008 at 05:31:13PM -0700, Mark Fasheh wrote:
> On Thu, Jul 10, 2008 at 05:15:44PM -0700, Joel Becker wrote:
> And use the full word, "recovery"! If we can't stand the extra bytes, then
> how about "ij_recovery_count", which is actually 1 byte shorter than
> "ij_reco_generation" anyway...
Hehe! I told him to use 'generation' because 'count' made me
think was talking about something else :-)
I don't care really, I agree that spelling it out is good for
something used in only a small bit of code. Pick either name
(ij_recovery_generation or ij_recovery_count) and go with it.
Joel
--
Life's Little Instruction Book #497
"Go down swinging."
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-07-11 0:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-10 23:17 [Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race Sunil Mushran
2008-07-10 23:17 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays Sunil Mushran
2008-07-11 0:15 ` Joel Becker
2008-07-11 0:31 ` Mark Fasheh
2008-07-11 0:46 ` Joel Becker [this message]
2008-07-11 3:05 ` SUNIL.MUSHRAN at ORACLE.COM
2008-07-10 23:17 ` [Ocfs2-devel] [PATCH 2/2] ocfs2: Fix race between mount and recovery Sunil Mushran
2008-07-11 0:36 ` Joel Becker
-- strict thread matches above, loose matches on Subject: below --
2008-07-11 23:27 [Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race (Attempt 2) Sunil Mushran
2008-07-11 23:27 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays Sunil Mushran
2008-07-12 0:25 [Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race (Attempt 3) Sunil Mushran
2008-07-12 0:25 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays Sunil Mushran
2008-07-14 20:12 [Ocfs2-devel] OCFS2 1.4: Proposed fix for mount/recovery race (Attempt 4) Sunil Mushran
2008-07-14 20:12 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays Sunil Mushran
2008-07-15 0:31 [Ocfs2-devel] Recovery/mount fixes for mainline Sunil Mushran
2008-07-15 0:31 ` [Ocfs2-devel] [PATCH 1/2] ocfs2: Adds counter in struct ocfs2_dinode to track journal replays Sunil Mushran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711004619.GJ11809@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.