All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Robin Rosenberg <robin.rosenberg@dewire.com>
Cc: git@vger.kernel.org, Marek Zawirski <marek.zawirski@gmail.com>
Subject: Re: [EGIT PATCH 2/6] Using the page site selection turned out to be cumbersome.
Date: Fri, 11 Jul 2008 03:52:49 +0000	[thread overview]
Message-ID: <20080711035249.GA32652@spearce.org> (raw)
In-Reply-To: <20080711034717.GA32633@spearce.org>

"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
> > +         <action
> > +               class="org.spearce.egit.ui.internal.actions.BranchAction"
> > +               id="org.spearce.egit.ui.action1"
> > +               label="Kolla"
> 
> What does this label mean?
> 
> > +         <action
> > +               class="org.spearce.egit.ui.internal.actions.ResetAction"
> > +               id="org.spearce.egit.ui.action1"
> > +               label="Titta"
> 
> Ditto.  You can use i18n translations in plugin.xml by putting these
> into a properties file and using %propertyname inside the XML.
> So we can prepare translations, but given that all of our source
> is documented in English I would prefer the property names to be
> the English name if we are going to start supporting translations.

Never mind, I see you fixed this in 6/6.  Don't bother reworking
the series of this minor issue.

-- 
Shawn.

  reply	other threads:[~2008-07-11  3:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-10 22:39 [EGIT PATCH 0/6] RevObject selection handler Robin Rosenberg
2008-07-10 22:39 ` [EGIT PATCH 1/6] Create a selection handler for the revision graph Robin Rosenberg
2008-07-10 22:39   ` [EGIT PATCH 2/6] Using the page site selection turned out to be cumbersome Robin Rosenberg
2008-07-10 22:39     ` [EGIT PATCH 3/6] Adapt Git team operations to non-resouce objects Robin Rosenberg
2008-07-10 22:39       ` [EGIT PATCH 4/6] Teach the revision selection handler about the active repository Robin Rosenberg
2008-07-10 22:39         ` [EGIT PATCH 5/6] Create baseclasses for actions and operations on RevObjects Robin Rosenberg
2008-07-10 22:39           ` [EGIT PATCH 6/6] Add actions in history view to perform reset actions Robin Rosenberg
2008-07-11  3:47     ` [EGIT PATCH 2/6] Using the page site selection turned out to be cumbersome Shawn O. Pearce
2008-07-11  3:52       ` Shawn O. Pearce [this message]
2008-07-11 11:14         ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711035249.GA32652@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=marek.zawirski@gmail.com \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.