From: Dave Chinner <david@fromorbit.com>
To: Timothy Shimmin <tes@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] Fix reference counting race on log buffers
Date: Fri, 11 Jul 2008 17:19:53 +1000 [thread overview]
Message-ID: <20080711071953.GR29319@disturbed> (raw)
In-Reply-To: <4876EED7.8060004@sgi.com>
On Fri, Jul 11, 2008 at 03:25:43PM +1000, Timothy Shimmin wrote:
> Dave,
>
> Yeah, looks good. Thanks.
Thanks, Tim - I'll add the right tags and send it to Linus.
> (My personal preference is for reversing if/else than using !
> as it is easier to read but whatever :)
It looked funny with one line in the upper branch, and I added
the comment inside the if() because it wasn't obvious from the
code (either way) which branch was the 'only ref' branch....
> But will need Eric's result before checking it in.
Seems like it's working fine, and i've got a coupl eof runs
through xfsqa now, so it should be good to go.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2008-07-11 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 5:01 [PATCH] Fix reference counting race on log buffers Dave Chinner
2008-07-11 5:25 ` Timothy Shimmin
2008-07-11 5:30 ` Timothy Shimmin
2008-07-11 7:19 ` Dave Chinner [this message]
2008-07-11 6:28 ` Eric Sandeen
2008-07-11 6:53 ` Mark Goodwin
[not found] ` <20080814180603.GA3087@infradead.org>
[not found] ` <48A4DB09.7020702@sgi.com>
[not found] ` <20080815012807.GA547@infradead.org>
[not found] ` <48A4F61E.3050106@sgi.com>
2008-08-15 22:07 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080711071953.GR29319@disturbed \
--to=david@fromorbit.com \
--cc=tes@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.