All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Masami Hiramatsu <mhiramat@redhat.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Hideo AOKI <haoki@redhat.com>, Takahiro Yasui <tyasui@redhat.com>
Subject: Re: [PATCH -mm] markers: avoid call_rcu_sched if old is NULL
Date: Fri, 11 Jul 2008 12:18:42 -0700	[thread overview]
Message-ID: <20080711121842.070c1342.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080709030200.GA4378@Krystal>

On Tue, 8 Jul 2008 23:02:01 -0400 Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca> wrote:

> * Masami Hiramatsu (mhiramat@redhat.com) wrote:
> > Introduce marker_entry_free_old() and check old pointer is NULL before
> > setting call_rcu_sched(), because marker_entry_remove/add_probe() can
> > return NULL.
> > 
> 
> Hi Masami,
> 
> I doubt this is a bug per se, because kfree accepts NULL pointers (and
> kfree is the only action done on the oldptr by free_old_closure).
> 
> This cleans up the code, so I think it's good to merge your patch, but I
> would definitely not classify this as a bugfix.
> 
> Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

I cannot get this to apply on the rather dated tree which I have on this
rather not-on-the-internet machine.  Please merge this patch locally, test,
rewrite the changelog and resend it to someone ;)


  parent reply	other threads:[~2008-07-11 19:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08 20:28 [PATCH -mm] markers: avoid call_rcu_sched if old is NULL Masami Hiramatsu
2008-07-09  3:02 ` Mathieu Desnoyers
2008-07-09  4:25   ` Mathieu Desnoyers
2008-07-11 19:18   ` Andrew Morton [this message]
2008-07-13  4:28     ` Mathieu Desnoyers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711121842.070c1342.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=haoki@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mhiramat@redhat.com \
    --cc=tyasui@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.