From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Roese <sr@denx.de>
Date: Fri, 11 Jul 2008 14:30:21 +0200
Subject: [U-Boot-Users] [PATCH] CPU PPC440x5 on Virtex5 FX
In-Reply-To: <4233.7021-17386-1090292077-1215778165@seznam.cz>
References: <4233.7021-17386-1090292077-1215778165@seznam.cz>
Message-ID: <200807111430.21562.sr@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Friday 11 July 2008, Michal Simek wrote:
> Some days ago a sent to mailing list patch (currently is in) where I rename
> CONFIG_XILINX_ML300 -> CONFIG_XILINX_405.
>
> I would like to see if you can use the same style for 440 ->
> CONFIG_XILINX_440. I have no detail information about ppc440 but IMHO only
> virtex5 fx (or whatever) support it -> make no sense to me use virtex5 in
> name.
>
> SR: Do you agree with me?

Yes, renaming this to CONFIG_XILINX_440 is a good idea.

> There is big part of code relate with interrupt controller which is the
> same with microblaze. This should be handled in the same way. Any
> suggestion? (Do generic driver?)

Yes, I already mentioned in my review, that this code should go into a 
separate file. If the microblaze implementation is the same or very similar 
then please use the same code here and move to to a common directory. 
Perhaps:

drivers/interrupt/xilinx.c ?

Comments?

> M
>
> BTW: some comments in code.

Michal, your comments are very hard to spot since you don't quote the original 
code by "> ".

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================