Re: [PATCH resend] ov7670: clean up ov7670_read semantics

[Andres Salomon <dilinger@queued.net>]

On Fri, 11 Jul 2008 15:19:19 -0700
Andrew Morton <akpm@linux-foundation.org> wrote:

> On Fri, 11 Jul 2008 16:52:16 -0400 Andres Salomon
> <dilinger@queued.net> wrote:
> 
> > [note: this should probably go in for 2.6.26, as it fixes a bug in
> > ov7670_s_fmt where we incorrectly think that we've failed because we
> > return !0]
> > 
> 
> In which case 2.6.25.x wants the fix as well?
> 

Yep!

[...]
> > diff --git a/drivers/media/video/ov7670.c
> > b/drivers/media/video/ov7670.c index 2bc6bdc..d7bfd30 100644
> > --- a/drivers/media/video/ov7670.c
> > +++ b/drivers/media/video/ov7670.c
> > @@ -406,8 +406,10 @@ static int ov7670_read(struct i2c_client *c,
> > unsigned char reg, int ret;
> 
> You have some wordwrapping happening there.
> 

Eek, thanks.  The original send wasn't line-wrapped, I'm not sure how
that happened.