All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
	"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"grundler@parisc-linux.org" <grundler@parisc-linux.org>,
	"mingo@elte.hu" <mingo@elte.hu>,
	"tglx@linutronix.de" <tglx@linutronix.de>,
	"jgarzik@pobox.com" <jgarzik@pobox.com>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	"benh@kernel.crashing.org" <benh@kernel.crashing.org>,
	"jbarnes@virtuousgeek.org" <jbarnes@virtuousgeek.org>,
	"rdunlap@xenotime.net" <rdunlap@xenotime.net>,
	"mtk.manpages@gmail.com" <mtk.manpages@gmail.com>
Subject: Re: Multiple MSI, take 3
Date: Fri, 11 Jul 2008 14:59:43 -0700	[thread overview]
Message-ID: <20080711215943.GW1678@linux-os.sc.intel.com> (raw)
In-Reply-To: <m1iqvc91li.fsf@frodo.ebiederm.org>

On Fri, Jul 11, 2008 at 03:06:33AM -0700, Eric W. Biederman wrote:
> Matthew Wilcox <matthew@wil.cx> writes:
> 
> > I'd like to thank Michael Ellerman for his feedback.  This is a much
> > better patchset than it used to be.
> 
> There is a reason we don't have an API to support this.  Linux can not
> reasonably support this, especially not on current X86.  The designers
> of the of the AHCI were idiots and should have used MSI-X.
> 
> Attempting to support multiple irqs in an MSI capability breaks
> every interesting use of an irq.
> 
> mask/unmask is will likely break because the mask bit is optional
> and when it is not present we disable the msi capability.
> 
> We can not set the affinity individually so we can not allow
> different queues to be processed on different cores.
> 
> So in general it seems something that we have to jump through a million
> hurdles and the result is someones twisted parody of a multiple working
> irqs, that even Intel's IOMMU can't cure.

With interrupt-remapping, we can program the individual interrupt
remapping table entries to point to different cpu's etc. All we have
to take care is, do the IRTE allocation in a consecutive block and
program the starting index to the MSI registers.

Just curious Eric, why do you think that won't work?

thanks,
suresh

> So unless the performance of the AHCI is better by a huge amount I don't
> see the point, and even then I am extremely sceptical.
> 
> Eric

  parent reply	other threads:[~2008-07-11 21:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-11  0:57 Multiple MSI, take 3 Matthew Wilcox
2008-07-11  0:59 ` [PATCH] PCI MSI: Replace 'type' with 'is_msix' Matthew Wilcox
2008-07-11  0:59 ` [PATCH] PCI: Add support for multiple MSI Matthew Wilcox
2008-07-11  8:28   ` Hidetoshi Seto
2008-07-11  9:45     ` Matthew Wilcox
2008-07-12  3:45     ` Benjamin Herrenschmidt
2008-07-11  1:00 ` [PATCH] Rewrite MSI-HOWTO Matthew Wilcox
2008-09-26  6:42   ` Grant Grundler
2008-07-11  1:00 ` [PATCH] AHCI: Request multiple MSIs Matthew Wilcox
2008-07-11  1:00 ` [PATCH] x86-64: Support for " Matthew Wilcox
2008-07-11  4:50   ` Kenji Kaneshige
2008-07-11  8:50     ` Matthew Wilcox
2008-07-14  1:08       ` Kenji Kaneshige
2008-07-11 10:06 ` Multiple MSI, take 3 Eric W. Biederman
2008-07-11 10:23   ` Matthew Wilcox
2008-07-11 10:32     ` David Miller
2008-07-11 10:41       ` Matthew Wilcox
2008-07-11 11:05     ` Eric W. Biederman
2008-07-11 11:34     ` Eric W. Biederman
2008-07-11 12:17       ` Matthew Wilcox
2008-07-11 15:10         ` Matthew Wilcox
2008-07-11 21:59   ` Suresh Siddha [this message]
2008-07-11 22:59     ` Eric W. Biederman
2008-07-11 23:15       ` Suresh Siddha
2008-07-11 23:59         ` Eric W. Biederman
2008-07-12  3:52       ` Benjamin Herrenschmidt
2008-07-12  4:41         ` Eric W. Biederman
2008-07-12  7:36           ` Benjamin Herrenschmidt
2008-07-13 22:30             ` Eric W. Biederman
2008-07-13 22:44               ` Benjamin Herrenschmidt
2008-07-13 23:29                 ` Eric W. Biederman
2008-07-14  0:17                   ` Benjamin Herrenschmidt
2008-07-14  0:44                     ` David Miller
2008-07-14  2:03                       ` Eric W. Biederman
2008-07-14  3:19                         ` David Miller
2008-09-26  5:30 ` Jike Song
2008-09-27 19:04   ` Matthew Wilcox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080711215943.GW1678@linux-os.sc.intel.com \
    --to=suresh.b.siddha@intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=ebiederm@xmission.com \
    --cc=grundler@parisc-linux.org \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=mingo@elte.hu \
    --cc=mtk.manpages@gmail.com \
    --cc=rdunlap@xenotime.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.