From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip] x86: apic LVTT - use APIC_DIVISOR on 64bit mode
Date: Sat, 12 Jul 2008 11:43:22 +0400 [thread overview]
Message-ID: <20080712074322.GB7010@asus> (raw)
In-Reply-To: <20080712073910.GA10689@elte.hu>
[Ingo Molnar - Sat, Jul 12, 2008 at 09:39:10AM +0200]
|
| * Cyrill Gorcunov <gorcunov@gmail.com> wrote:
|
| > @@ -329,7 +332,7 @@ static void __init calibrate_APIC_clock(
| > *
| > * No interrupt enable !
| > */
| > - __setup_APIC_LVTT(250000000, 0, 0);
| > + __setup_APIC_LVTT(4000000000, 0, 0);
|
| note how close it is to 2^32. For this to be unifiable later on this
| needs to be UL i guess, and this:
|
| > - calibration_result = result / HZ;
| > + calibration_result = result * APIC_DIVISOR / HZ;
|
| might overflow 32 bits.
|
| Ingo
|
hmm... I need more time for analisys, thanks. Drop this patch
please
- Cyrill -
next prev parent reply other threads:[~2008-07-12 7:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 19:02 [PATCH -tip] x86: apic LVTT - use APIC_DIVISOR on 64bit mode Cyrill Gorcunov
2008-07-12 6:05 ` Ingo Molnar
2008-07-12 7:22 ` Cyrill Gorcunov
2008-07-12 7:39 ` Ingo Molnar
2008-07-12 7:43 ` Cyrill Gorcunov [this message]
2008-07-12 7:37 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080712074322.GB7010@asus \
--to=gorcunov@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.