All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Tom Zanussi <tzanussi@gmail.com>,
	kosaki.motohiro@jp.fujitsu.com
Subject: Re: [mmotm] relay: fix build error
Date: Sat, 12 Jul 2008 19:40:38 +0300	[thread overview]
Message-ID: <20080712194038.5833d880@linux360.ro> (raw)
In-Reply-To: <20080712201206.F6B0.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Sat, 12 Jul 2008 20:14:21 +0900
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> against: mmotm
> patchname:
> relay-add-buffer-only-channels-useful-for-early-logging-fix.patch
> applies after:
> relay-add-buffer-only-channels-useful-for-early-logging.patch
> 
> recently, smp_call_function remove retry argument.
> it cause following build error on mmotm.
> 
> 	kernel/relay.c: In function ‘relay_late_setup_files’:
> 	kernel/relay.c:754: error: too many arguments to function
> ‘smp_call_function_single’ make[1]: *** [kernel/relay.o] error 1
> 
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>
> Cc: Tom Zanussi <tzanussi@gmail.com>
> CC: Andrew Morton <akpm@linux-foundation.org>

Thanks.

If it matters...
Acked-by: Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>

> ---
>  kernel/relay.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: b/kernel/relay.c
> ===================================================================
> --- a/kernel/relay.c
> +++ b/kernel/relay.c
> @@ -751,7 +751,7 @@ int relay_late_setup_files(struct rchan 
>  			/* relay_channels_mutex must be held, so
> wait. */ err = smp_call_function_single(i,
>  						       __relay_set_buf_dentry,
> -						       &disp, 0, 1);
> +						       &disp, 1);
>  		}
>  		if (unlikely(err))
>  			break;
> 

      reply	other threads:[~2008-07-12 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-12 11:14 [mmotm] relay: fix build error KOSAKI Motohiro
2008-07-12 16:40 ` Eduard - Gabriel Munteanu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080712194038.5833d880@linux360.ro \
    --to=eduard.munteanu@linux360.ro \
    --cc=akpm@linux-foundation.org \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.