From: Andrew Morton <akpm@linux-foundation.org>
To: "Jakub W. Jozwicki" <jozwicki@aster.pl>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic
Date: Sun, 13 Jul 2008 01:26:30 -0700 [thread overview]
Message-ID: <20080713012630.d5e522f7.akpm@linux-foundation.org> (raw)
In-Reply-To: <200807130127.36706.jozwicki@aster.pl>
On Sun, 13 Jul 2008 01:27:36 +0200 "Jakub W. Jozwicki" <jozwicki@aster.pl> wrote:
> Change locking surrounding kmap_atomic from local_irqsave to
> local_irqsave_nort. This fixes issues with PREEMPT_RT.
>
I assume this is a -rt kernel patch.
>
> --- linux-2.6.25.10/drivers/ata/libata-core.c 2008-07-03 05:46:47.000000000
> +0200
> +++ linux-2.6.25.10-rt7/drivers/ata/libata-core.c 2008-07-12
> 23:59:33.132140258 +0200
> @@ -5157,14 +5157,14 @@
> unsigned long flags;
>
> /* FIXME: use a bounce buffer */
> - local_irq_save(flags);
> + local_irq_save_nort(flags);
eww. If we're going to have to do stuff like this in mainline then
there might be a revolt.
next prev parent reply other threads:[~2008-07-13 8:26 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 23:27 [PATCH 2.6.25.10 1/2] libata: fix locking for kmap_atomic Jakub W. Jozwicki
2008-07-13 8:26 ` Andrew Morton [this message]
2008-07-13 13:17 ` Jakub W. Jozwicki
2008-07-13 17:46 ` Jeremy Fitzhardinge
2008-07-13 18:53 ` Jakub W. Jozwicki
2008-07-13 21:32 ` Jeremy Fitzhardinge
2008-07-13 10:25 ` Alan Cox
2008-07-13 13:30 ` Jakub W. Jozwicki
2008-07-13 14:15 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080713012630.d5e522f7.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jozwicki@aster.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.