From: David Brownell <david-b@pacbell.net>
To: Andrew Morton <akpm@linux-foundation.org>,
Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
Haavard Skinnemoen <haavard.skinnemoen@atmel.com>,
Russell King <rmk+lkml@arm.linux.org.uk>,
Paul Mundt <lethal@linux-sh.org>,
pHilipp Zabel <philipp.zabel@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
tony@atomide.com, paul@pwsan.com,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
ian <spyro@f2s.com>
Subject: Re: [PATCH 1/3] genclk: add generic framework for managing clocks.
Date: Sun, 13 Jul 2008 14:12:32 -0700 [thread overview]
Message-ID: <200807131412.32961.david-b@pacbell.net> (raw)
In-Reply-To: <20080712234823.e632c7f9.akpm@linux-foundation.org>
On Saturday 12 July 2008, Andrew Morton wrote:
> > +EXPORT_SYMBOL(clk_get_parent);
>
> As this is a new kernel-wide utility library, it is appropriate that
> all of its public interfaces (at least) be documented. An appropriate
> way of doing that is via kerneldoc annotation. Please don't forget to
> document return values and call environment prerequisites (eg: requires
> foo_lock, may be called from interrupt context, etc, etc).
That is, the stuff that's not already documented in <linux/clk.h>;
that's where clk_get_parent() is documented, for example.
I'd suggest a separate (for review!) doc patch to add this to the
stuff that's at the end of Documentation/DocBook/kernel-api.tmpl
in 2.6.26 ... possibly the existing clk.h interface stuff should
become a <sect1> and the new implementation glue should become
a sibling <sect1>, that will cleanly separate the two.
- Dave
next prev parent reply other threads:[~2008-07-13 21:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 13:42 [PATCH 0/3] Genclk: generic framework for clocks managing [v3.1] Dmitry Baryshkov
2008-07-08 13:43 ` [PATCH 1/3] genclk: add generic framework for managing clocks Dmitry Baryshkov
2008-07-13 6:48 ` Andrew Morton
2008-07-13 20:53 ` Dmitry
2008-07-13 21:03 ` Andrew Morton
2008-07-13 21:12 ` David Brownell [this message]
2008-07-13 21:23 ` Andrew Morton
2008-07-13 21:54 ` David Brownell
2008-07-14 22:30 ` Russell King
2008-07-14 21:00 ` Dmitry Baryshkov
2008-07-08 13:43 ` [PATCH 2/3] Refactor arm/pxa to use generic clocks support Dmitry Baryshkov
2008-07-08 13:44 ` [PATCH 3/3] Clocklib: refactor SA-1100 to use clocklib Dmitry Baryshkov
2008-07-08 14:07 ` [PATCH 0/3] Genclk: generic framework for clocks managing [v3.1] Ben Dooks
2008-07-08 14:28 ` Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807131412.32961.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=akpm@linux-foundation.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dbaryshkov@gmail.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=spyro@f2s.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.