From: "Jakub W. Jozwicki" <jozwicki@aster.pl>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, mgross@linux.intel.com,
mingo@elte.hu, tglx@timesys.com
Subject: Re: [PATCH 2.6.25.10] pm_qos_params: change spinlock to rwlock
Date: Sun, 13 Jul 2008 15:05:25 +0200 [thread overview]
Message-ID: <200807131505.25990.jozwicki@aster.pl> (raw)
In-Reply-To: <20080713012816.8c136efa.akpm@linux-foundation.org>
Sunday, 13 of July 2008 10:28:16 Andrew Morton napisał(a):
> On Sun, 13 Jul 2008 01:19:19 +0200 "Jakub W. Jozwicki" <jozwicki@aster.pl>
wrote:
> > Concurrent calls to pm_qos_requirement shouldn't block each other. This
> > patch changes spinlock to rwlock and fixes issues with PREEMPT_RT.
>
> "fixes issues" is nowhere near an adequate description.
>
> Please provide complete descriptions for kernel patches. That includes
> describing the mysterious "issue" in full!
>
> Thanks.
[ 114.647010] BUG: sleeping function called from invalid context swapper(0)
at kernel/rtmutex.c:742
[ 114.647010] in_atomic():1 [00000001], irqs_disabled():0
[ 114.647010] Pid: 0, comm: swapper Not tainted 2.6.25.10-rtXXX #10
[ 114.647010] [<c0120fc4>] __might_sleep+0xf1/0xf8
[ 114.647010] [<c045499c>] __rt_spin_lock+0x24/0x61
[ 114.647010] [<c04549e1>] rt_spin_lock+0x8/0xa
[ 114.647010] [<c013ec8d>] pm_qos_requirement+0x10/0x29
[ 114.647010] [<c038ef36>] menu_select+0x5d/0x7f
[ 114.647010] [<c038e4d8>] cpuidle_idle_call+0x47/0x9b
[ 114.647010] [<c038e491>] ? cpuidle_idle_call+0x0/0x9b
[ 114.647010] [<c01060ff>] cpu_idle+0xaf/0x106
[ 114.647010] [<c0441c87>] rest_init+0x67/0x69
[ 114.647010] =======================
[ 115.649517] BUG: sleeping function called from invalid context swapper(0)
at kernel/rtmutex.c:742
[ 115.649517] in_atomic():1 [00000001], irqs_disabled():0
[ 115.649517] Pid: 0, comm: swapper Not tainted 2.6.25.10-rtXXX #10
[ 115.649517] [<c0120fc4>] __might_sleep+0xf1/0xf8
[ 115.649517] [<c045499c>] __rt_spin_lock+0x24/0x61
[ 115.649517] [<c04549e1>] rt_spin_lock+0x8/0xa
[ 115.649517] [<c013ec8d>] pm_qos_requirement+0x10/0x29
[ 115.649517] [<c038ef36>] menu_select+0x5d/0x7f
[ 115.649517] [<c038e4d8>] cpuidle_idle_call+0x47/0x9b
[ 115.649517] [<c038e491>] ? cpuidle_idle_call+0x0/0x9b
[ 115.649517] [<c01060ff>] cpu_idle+0xaf/0x106
[ 115.649517] [<c0441c87>] rest_init+0x67/0x69
[ 115.649517] =======================
[ 116.650040] BUG: sleeping function called from invalid context swapper(0)
at kernel/rtmutex.c:742
[ 116.650040] in_atomic():1 [00000001], irqs_disabled():0
[ 116.650040] Pid: 0, comm: swapper Not tainted 2.6.25.10-rtXXX #10
[ 116.650040] [<c0120fc4>] __might_sleep+0xf1/0xf8
[ 116.650040] [<c045499c>] __rt_spin_lock+0x24/0x61
[ 116.650040] [<c04549e1>] rt_spin_lock+0x8/0xa
[ 116.650040] [<c013ec8d>] pm_qos_requirement+0x10/0x29
[ 116.650040] [<c038ef36>] menu_select+0x5d/0x7f
[ 116.650040] [<c038e4d8>] cpuidle_idle_call+0x47/0x9b
[ 116.650040] [<c038e491>] ? cpuidle_idle_call+0x0/0x9b
[ 116.650040] [<c01060ff>] cpu_idle+0xaf/0x106
[ 116.650040] [<c0441c87>] rest_init+0x67/0x69
[ 116.650040] =======================
next prev parent reply other threads:[~2008-07-13 13:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 23:19 [PATCH 2.6.25.10] pm_qos_params: change spinlock to rwlock Jakub W. Jozwicki
2008-07-13 8:28 ` Andrew Morton
2008-07-13 13:05 ` Jakub W. Jozwicki [this message]
2008-07-15 0:17 ` mark gross
2008-08-22 13:14 ` Nicos Gollan
2008-07-16 17:15 ` mark gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807131505.25990.jozwicki@aster.pl \
--to=jozwicki@aster.pl \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=mingo@elte.hu \
--cc=tglx@timesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.