All of lore.kernel.org
 help / color / mirror / Atom feed
From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Zhang Rui <rui.zhang@intel.com>,
	Bob Moore <robert.moore@intel.com>,
	Thomas Renninger <trenn@suse.de>, Len Brown <lenb@kernel.org>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>,
	Heiko Carstens <heiko.carstens@de.ibm.com>,
	linux390@de.ibm.com, linux-s390@vger.kernel.org
Subject: [patch -mmotm 1/6] move memory_read_from_buffer() from fs.h to string.h
Date: Mon, 14 Jul 2008 11:56:32 +0900	[thread overview]
Message-ID: <20080714025737.954072047@gmail.com> (raw)
In-Reply-To: 20080714025631.338886297@gmail.com

[-- Attachment #1: move-memory-read-from-buffer-into-string-h.patch --]
[-- Type: text/plain, Size: 2667 bytes --]

James Bottomley warns that inclusion of linux/fs.h in a low level driver
was always a danger signal. This patch moves memory_read_from_buffer()
from fs.h to string.h and remove inclusion of linux/fs.h in existing
memory_read_from_buffer() user.

Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Zhang Rui <rui.zhang@intel.com>
Cc: Bob Moore <robert.moore@intel.com>
Cc: Thomas Renninger <trenn@suse.de>
Cc: Len Brown <lenb@kernel.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: linux390@de.ibm.com
Cc: linux-s390@vger.kernel.org
---
 arch/s390/kernel/ipl.c      |    1 -
 drivers/zorro/zorro-sysfs.c |    1 -
 include/linux/fs.h          |    2 --
 include/linux/string.h      |    3 +++
 4 files changed, 3 insertions(+), 4 deletions(-)

Index: 2.6-mmotm/include/linux/fs.h
===================================================================
--- 2.6-mmotm.orig/include/linux/fs.h
+++ 2.6-mmotm/include/linux/fs.h
@@ -2028,8 +2028,6 @@ extern void simple_release_fs(struct vfs
 
 extern ssize_t simple_read_from_buffer(void __user *to, size_t count,
 			loff_t *ppos, const void *from, size_t available);
-extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
-			const void *from, size_t available);
 
 #ifdef CONFIG_MIGRATION
 extern int buffer_migrate_page(struct address_space *,
Index: 2.6-mmotm/include/linux/string.h
===================================================================
--- 2.6-mmotm.orig/include/linux/string.h
+++ 2.6-mmotm/include/linux/string.h
@@ -111,5 +111,8 @@ extern void argv_free(char **argv);
 
 extern bool sysfs_streq(const char *s1, const char *s2);
 
+extern ssize_t memory_read_from_buffer(void *to, size_t count, loff_t *ppos,
+			const void *from, size_t available);
+
 #endif
 #endif /* _LINUX_STRING_H_ */
Index: 2.6-mmotm/drivers/zorro/zorro-sysfs.c
===================================================================
--- 2.6-mmotm.orig/drivers/zorro/zorro-sysfs.c
+++ 2.6-mmotm/drivers/zorro/zorro-sysfs.c
@@ -15,7 +15,6 @@
 #include <linux/zorro.h>
 #include <linux/stat.h>
 #include <linux/string.h>
-#include <linux/fs.h>
 
 #include "zorro.h"
 
Index: 2.6-mmotm/arch/s390/kernel/ipl.c
===================================================================
--- 2.6-mmotm.orig/arch/s390/kernel/ipl.c
+++ 2.6-mmotm/arch/s390/kernel/ipl.c
@@ -14,7 +14,6 @@
 #include <linux/delay.h>
 #include <linux/reboot.h>
 #include <linux/ctype.h>
-#include <linux/fs.h>
 #include <asm/ipl.h>
 #include <asm/smp.h>
 #include <asm/setup.h>

-- 

  reply	other threads:[~2008-07-14  2:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-14  2:56 [patch -mmotm 0/6] move memory_read_from_buffer() from fs.h to string.h Akinobu Mita
2008-07-14  2:56 ` Akinobu Mita [this message]
2008-07-14  2:56 ` [patch -mmotm 2/6] fix qla2xxx-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-17 23:12   ` Andrew Vasquez
2008-07-17 23:28     ` Andrew Morton
2008-07-17 23:44       ` Andrew Vasquez
2008-07-17 23:46         ` Andrew Morton
2008-07-14  2:56 ` [patch -mmotm 3/6] fix dcdbas-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-14  2:56 ` [patch -mmotm 4/6] fix aty-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-14  2:56 ` [patch -mmotm 5/6] fix firmware-use-memory_read_from_buffer.patch Akinobu Mita
2008-07-14  2:56 ` [patch -mmotm 6/6] fix dell_rbu-use-memory_read_from_buffer.patch Akinobu Mita

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080714025737.954072047@gmail.com \
    --to=akinobu.mita@gmail.com \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=heiko.carstens@de.ibm.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux390@de.ibm.com \
    --cc=robert.moore@intel.com \
    --cc=rui.zhang@intel.com \
    --cc=schwidefsky@de.ibm.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.