From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
Subject: RE: [PATCH] clocksource=tsc
Date: Tue, 15 Jul 2008 08:44:31 -0600
Message-ID: <20080715084431031.00000080236@djm-pc>
References: <C4A25F1A.23FE1%keir.fraser@eu.citrix.com>
Reply-To: "dan.magenheimer@oracle.com" <dan.magenheimer@oracle.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <C4A25F1A.23FE1%keir.fraser@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Keir Fraser <keir.fraser@eu.citrix.com>, "Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>
Cc: Dave Winchell <dwinchell@virtualiron.com>
List-Id: xen-devel@lists.xenproject.org

> Changeset 18055 is what I had in mind. I split out the
> read_counter-is-64-bit portion separately. The changeset =

> needs a bit of
> testing and it may need a tweak or two.

Hmmm... One thing I was trying to do with the special
casing in get_s_time() was to avoid using a dynamically
changing scaling (t->tsc_scale).  If I'm not mistaken,
t->tsc_scale is recalculated every EPOCH and thus is
a potential source of stime jitter.  Seems unnecessary
just to make the code look cleaner.

One other nit:  Especially if the above is changed, do
you really prefer a strcmp vs a global variable (or
checking for size =3D=3D 64) for determining if the tsc
is the platform timer?

Thanks,
Dan