From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH][TOOLS] xenperf: cleanup Date: Tue, 15 Jul 2008 16:06:35 +0200 Message-ID: <200807151606.36016.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Tuesday 15 July 2008 15:52:13 Keir Fraser wrote: > On 15/7/08 14:45, "Christoph Egger" wrote: > > One more (already sent). Then the tools build with the additional > > compiler flags: > > > > -Wstrict-prototypes -Wswitch -Wmissing-prototypes -Wreturn-type > > -Wnested-externs > > -Wredundant-decls -Wfloat-equal -Wundef -Wimplicit-function-declaration > > Do we really want these? Certainly I'm not going to play whack-a-warning > with umpteen versions of gcc before 3.3 is out. Probably not all of them. -Wfloat-equal has no effect because there's no FP= U=20 code in Xen. The flags -Wmissing-prototypes -Wnested-externs -Wredundant-decls and -Wimplicit-function-declaration resulted in the patches I sent=20 yesterday and today. These flags guarantee that future patches have a higher quality. =46or the xen-kernel itself I'm not yet through with these flags. Nonetheless, I can send a patch you will like. :) Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy