From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] ioemu-remote: Fix pci pass-through
Date: Tue, 15 Jul 2008 17:36:28 +0100
Message-ID: <20080715163628.GU4529@implementation.uk.xensource.com>
References: <487CCE11.90201@eu.citrix.com> <487CCE78.9070004@eu.citrix.com>
	<487CCF5D.9090200@eu.citrix.com> <487CCE11.90201@eu.citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <487CCF5D.9090200@eu.citrix.com> <487CCE11.90201@eu.citrix.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Jean Guyader <jean.guyader@eu.citrix.com>
Cc: xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Hmm, I have already provided fixes for all these patches.  IanJ, it is
part of the patches I've sent you.

Jean Guyader, le Tue 15 Jul 2008 17:19:29 +0100, a =E9crit :
> diff --git a/xen-hooks.mak b/xen-hooks.mak
> index 4e8b1fa..af977ef 100644
> --- a/xen-hooks.mak
> +++ b/xen-hooks.mak
> @@ -39,11 +39,20 @@ OBJS +=3D tpm_tis.o
> =20
>  ifdef CONFIG_STUBDOM
>  CONFIG_PASSTHROUGH=3D1
> -OBJS +=3D xenfbfront.o
> +else
> +  ifeq (,$(wildcard /usr/include/pci))
> +$(warning *** pciutils-devl package not found - missing /usr/include/p=
ci)
> +$(warning *** PCI passthrough capability has been disabled)
> +  else
> +CONFIG_PASSTHROUGH=3D1
> +  endif
>  endif
> =20
>  ifdef CONFIG_PASSTHROUGH
> -OBJS+=3D pass-through.o
> +OBJS+=3D pass-through.o pt-msi.o
> +LIBS +=3D -lpci
> +CFLAGS +=3D -DCONFIG_PASSTHROUGH=20
> +$(info *** PCI passthrough capability has been enabled ***)
>  endif
> =20
>  BAD_OBJS +=3D gdbstub.o acpi.o apic.o

> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel


Jean Guyader, le Tue 15 Jul 2008 17:25:01 +0100, a =E9crit :
> ioemu-remote: Fix the pass-through compilation.
>=20
> Signed-off-by: Jean Guyader <jean.guyader@eu.citrix.com>
>=20
> --=20
> Jean Guyader

> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index bddc203..f29f07d 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -713,7 +713,7 @@ int pt_init(PCIBus *e_bus, char *direct_pci)
>      dpci_infos.pci_access =3D pci_access;
>      dpci_infos.e_bus      =3D e_bus;
> =20
> -    if ( strlen(direct_pci) =3D=3D 0 ) {
> +    if ( !direct_pci || strlen(direct_pci) =3D=3D 0 ) {
>          return 0;
>      }
> =20
> diff --git a/hw/pass-through.h b/hw/pass-through.h
> index ffd87ef..d642be3 100644
> --- a/hw/pass-through.h
> +++ b/hw/pass-through.h
> @@ -27,7 +27,7 @@
>  #define PT_LOGGING_ENABLED
> =20
>  #ifdef PT_LOGGING_ENABLED
> -#define PT_LOG(_f, _a...)   fprintf(logfile, "%s: " _f, __func__, ##_a=
)
> +#define PT_LOG(_f, _a...)   fprintf(stdout, "%s: " _f, __func__, ##_a)
>  #else
>  #define PT_LOG(_f, _a...)
>  #endif