From: "SZEDER Gábor" <szeder@ira.uka.de>
To: Kevin Ballard <kevin@sb.org>
Cc: Git Mailing List <git@vger.kernel.org>,
pape@smarden.org, Eric Wong <normalperson@yhbt.net>
Subject: Re: Breakage caused by 2fe403e7 git-svn.perl: workaround assertions in svn library 1.5.0
Date: Wed, 16 Jul 2008 15:45:10 +0200 [thread overview]
Message-ID: <20080716134510.GA6831@neumann> (raw)
In-Reply-To: <6583867F-ED86-4E3D-AE8B-39FB974C43D7@sb.org>
Hi,
On Tue, Jul 08, 2008 at 05:41:48PM -0700, Kevin Ballard wrote:
> Commit 2fe403e7 causes `git svn info` and `git svn info .` to break.
>
> Use of uninitialized value in localtime at /usr/local/libexec/git-
> core/git-svn line 4277.
> No such file or directory at /usr/local/libexec/git-core/git-svn line
> 897.
>
> If it makes a difference, I have svn 1.4.4 installed, not svn 1.5.
the same problem here, except that I have svn v1.4.6.
The patch in question adds the following line to git-svn.perl's
canonicalize_path():
+ $path =~ s#^\.$##;
which makes an empty string from the path ".". This is especially
unfortunate for 'git svn info', cmd_info() begins with
my $path = canonicalize_path(shift or ".");
and from that point everything is ruined, but it boils out only when
it tries to actually open() the empty path.
Removing the mentioned line from canonicalize_path() does resolve this
issue on svn v1.4.6, but I'm afraid it will brake again on svn v1.5.
Gábor
prev parent reply other threads:[~2008-07-16 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 0:41 Breakage caused by 2fe403e7 git-svn.perl: workaround assertions in svn library 1.5.0 Kevin Ballard
2008-07-16 13:45 ` SZEDER Gábor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080716134510.GA6831@neumann \
--to=szeder@ira.uka.de \
--cc=git@vger.kernel.org \
--cc=kevin@sb.org \
--cc=normalperson@yhbt.net \
--cc=pape@smarden.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.