From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759442AbYGPQRY (ORCPT ); Wed, 16 Jul 2008 12:17:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756910AbYGPQRR (ORCPT ); Wed, 16 Jul 2008 12:17:17 -0400 Received: from tomts16-srv.bellnexxia.net ([209.226.175.4]:46388 "EHLO tomts16-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755734AbYGPQRQ (ORCPT ); Wed, 16 Jul 2008 12:17:16 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtUEANG4fUhMRKxB/2dsb2JhbACBWq8a Date: Wed, 16 Jul 2008 12:17:14 -0400 From: Mathieu Desnoyers To: KOSAKI Motohiro Cc: Peter Zijlstra , akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Masami Hiramatsu , linux-mm@kvack.org, Dave Hansen , "Frank Ch. Eigler" , Hideo AOKI , Takashi Nishiie , Steven Rostedt , Eduard - Gabriel Munteanu Subject: Re: [patch 10/17] LTTng instrumentation - swap Message-ID: <20080716161714.GA31889@Krystal> References: <1216219654.5232.55.camel@twins> <20080716150046.GI24546@Krystal> <20080717004734.1579.KOSAKI.MOTOHIRO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20080717004734.1579.KOSAKI.MOTOHIRO@jp.fujitsu.com> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 12:16:51 up 41 days, 20:57, 5 users, load average: 0.39, 0.47, 0.62 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote: > Hi > > > > > Would it make more sense to turn get_swap_info_struct into a static > > > > inline in swap.h ? > > > > > > Seeing a consumer of it would go a long way towards discussing it ;-) > > > > The LTTng probe which connects to this tracepoint looks like : > > I have no objection to this exporting. > > However, This is LTTng requirement. > but tracepoint is tracer independent mechanism. > then, split out is better IMHO. > Good point. I'll move it to my following lttng-specific patches. Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from toip6.srvr.bell.ca ([209.226.175.125]) by tomts10-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20080716161715.TMWN1721.tomts10-srv.bellnexxia.net@toip6.srvr.bell.ca> for ; Wed, 16 Jul 2008 12:17:15 -0400 Date: Wed, 16 Jul 2008 12:17:14 -0400 From: Mathieu Desnoyers Subject: Re: [patch 10/17] LTTng instrumentation - swap Message-ID: <20080716161714.GA31889@Krystal> References: <1216219654.5232.55.camel@twins> <20080716150046.GI24546@Krystal> <20080717004734.1579.KOSAKI.MOTOHIRO@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20080717004734.1579.KOSAKI.MOTOHIRO@jp.fujitsu.com> Sender: owner-linux-mm@kvack.org Return-Path: To: KOSAKI Motohiro Cc: Peter Zijlstra , akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Masami Hiramatsu , linux-mm@kvack.org, Dave Hansen , "Frank Ch. Eigler" , Hideo AOKI , Takashi Nishiie , Steven Rostedt , Eduard - Gabriel Munteanu List-ID: * KOSAKI Motohiro (kosaki.motohiro@jp.fujitsu.com) wrote: > Hi > > > > > Would it make more sense to turn get_swap_info_struct into a static > > > > inline in swap.h ? > > > > > > Seeing a consumer of it would go a long way towards discussing it ;-) > > > > The LTTng probe which connects to this tracepoint looks like : > > I have no objection to this exporting. > > However, This is LTTng requirement. > but tracepoint is tracer independent mechanism. > then, split out is better IMHO. > Good point. I'll move it to my following lttng-specific patches. Mathieu -- Mathieu Desnoyers OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org