All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-embedded@ozlabs.org
Cc: linuxppc-dev@ozlabs.org, Victor Gallardo <vgallard@amcc.com>,
	fkan@amcc.com
Subject: Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x
Date: Wed, 16 Jul 2008 16:46:01 +0200	[thread overview]
Message-ID: <200807161646.02306.arnd@arndb.de> (raw)
In-Reply-To: <20080716141539.GC24045@secretlab.ca>

On Wednesday 16 July 2008, Grant Likely wrote:
>=20
> >=20
> > And then you don't need this file at all. =A0Just add a
> > "amcc,canyonlands" string to your root node compatible property.
>=20
> No! =A0Don't do this because it is not true!
>=20
> Instead, add your board name to canyonlands.c in canyonlands_probe().
> It's not the most scalable solution, but it keeps you from lying about
> your hardware in the .dts file.
>=20
> I'm working on a more scalable solution for this, but for now just add
> your specific board to canyonlands_probe().

Shouldn't it be enough to have a common compatible value in each
of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the
specific type unless you need to do something special?

=46or all I can tell, bamboo, canyonlands, katmai, rainier, sequoia
and taishan setup is already identical except for their names, while
ebony and Sam440ep are almost the same, except for their RTC device
probing (which should be done in a generic way as well ;-)).

	Arnd <><

  parent reply	other threads:[~2008-07-16 14:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  5:33 [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x fkan
2008-07-16 11:50 ` Josh Boyer
2008-07-16 14:15   ` Grant Likely
2008-07-16 14:37     ` Josh Boyer
2008-07-16 15:43       ` Grant Likely
2008-07-17  3:15       ` Segher Boessenkool
2008-07-16 14:46     ` Arnd Bergmann [this message]
2008-07-16 15:46       ` Grant Likely
2008-07-16 22:58         ` Arnd Bergmann
2008-07-17  2:15           ` Josh Boyer
2008-07-17  3:24           ` Segher Boessenkool
2008-07-17  3:19         ` Segher Boessenkool
2008-07-18 22:31   ` Victor Gallardo
2008-07-19 13:44     ` Josh Boyer
2008-07-22 19:35       ` Victor Gallardo
2008-07-18 14:24 ` Stefan Roese
2008-07-18 22:24   ` Victor Gallardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807161646.02306.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=fkan@amcc.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=linuxppc-embedded@ozlabs.org \
    --cc=vgallard@amcc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.