Re: pull request: wireless-next-2.6 2008-07-14

["John W. Linville" <linville@tuxdriver.com>]

On Wed, Jul 16, 2008 at 01:00:07PM -0700, David Miller wrote:
> From: "Tomas Winkler" <tomasw@gmail.com>
> Date: Wed, 16 Jul 2008 15:49:34 +0300
> 
> > On Tue, Jul 15, 2008 at 6:45 AM, David Miller <davem@davemloft.net> wrote:
> > > From: "John W. Linville" <linville@tuxdriver.com>
> > > Date: Mon, 14 Jul 2008 15:23:02 -0400
> > >
> > > drivers/net/wireless/iwlwifi/iwl-led.c:271: warning: format '%lld' expects type 'long long int', but argument 6 has type 's64'
> > > drivers/net/wireless/iwlwifi/iwl-led.c:271: warning: format '%lld' expects type 'long long int', but argument 7 has type 'u64'
> > 
> > I cannot reproduce this. Wasn't this conversion already solved or
> > still need to cast to long long int?
> 
> You have to cast u64/s64 values to long long if you want to print them
> using %llX specifiers, because some 64-bit platforms define these
> types as plain "long".

There were a number of such warnings fixed in iwlwifi previously.
It is possible that either one got lost in a merge conflict or this
new one simply is reminding Tomas of one of the old ones.  Either way,
it seems to be fixed now.

John
-- 
John W. Linville
linville@tuxdriver.com