From: David Miller <davem@davemloft.net>
To: m.kozlowski@tuxland.pl
Cc: jie.yang@atheros.com, jeff@garzik.org, yjwei@cn.fujitsu.com,
rdreier@cisco.com, shemminger@vyatta.com, jcliburn@gmail.com,
parag.warudkar@gmail.com, w@1wt.eu,
oliver.schuster@schweigstill.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver
Date: Thu, 17 Jul 2008 14:37:53 -0700 (PDT) [thread overview]
Message-ID: <20080717.143753.250293973.davem@davemloft.net> (raw)
In-Reply-To: <200807172204.15342.m.kozlowski@tuxland.pl>
From: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Date: Thu, 17 Jul 2008 22:04:14 +0200
> Hello,
>
> > +#define SPEED_0 0xffff
> > +#define SPEED_10 10
> > +#define SPEED_100 100
> > +#define SPEED_100 100
>
> Small thing - double define for SPEED_100.
>
> > +#define SPEED_1000 1000
And these are all entirely superfluous, since they are already defined
in linux/ethtool.h
next prev parent reply other threads:[~2008-07-17 21:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 9:04 [PATCH net-next] atl1e: Atheros L1E Gigabit Ethernet driver jie.yang
2008-07-17 9:31 ` Alexey Dobriyan
2008-07-17 9:41 ` Jie Yang
2008-07-17 15:44 ` Stephen Hemminger
2008-07-17 20:04 ` Mariusz Kozlowski
2008-07-17 20:23 ` Ben Hutchings
2008-07-17 21:37 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-18 3:37 jie.yang
2008-07-22 23:31 ` Jeff Garzik
2008-07-14 3:28 Jie Yang
2008-07-16 4:15 ` Stephen Hemminger
2008-07-16 9:42 ` Jie Yang
2008-07-16 15:53 ` Stephen Hemminger
2008-07-16 16:36 ` Roland Dreier
2008-07-17 2:47 ` Jie Yang
2008-07-17 3:30 ` Wei Yongjun
2008-07-17 3:34 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717.143753.250293973.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jcliburn@gmail.com \
--cc=jeff@garzik.org \
--cc=jie.yang@atheros.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=oliver.schuster@schweigstill.de \
--cc=parag.warudkar@gmail.com \
--cc=rdreier@cisco.com \
--cc=shemminger@vyatta.com \
--cc=w@1wt.eu \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.