From: Michael Buesch <mb@bu3sch.de>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, Ivo van Doorn <ivdoorn@gmail.com>
Subject: Re: [PATCH 4/4] rfkill: mutex fixes
Date: Thu, 17 Jul 2008 06:56:36 +0200 [thread overview]
Message-ID: <200807170656.37190.mb@bu3sch.de> (raw)
In-Reply-To: <1216150327-10904-5-git-send-email-hmh@hmh.eng.br>
On Tuesday 15 July 2008, Henrique de Moraes Holschuh wrote:
> There are two mutexes in rfkill:
>
> rfkill->mutex, which protects some of the fields of a rfkill struct, and is
> also used for callback serialization.
>
> rfkill_mutex, which protects the global state, the list of registered
> rfkill structs and rfkill->claim.
>
> Make sure to use the correct mutex, and to not miss locking rfkill->mutex
> even when we already took rfkill_mutex.
Can't we rename the global rfkill_mutex?
I think the current situation is highly confusing.
Perhaps rfkill_global_mutex would be good enough. Maybe somebody has a better
idea, however.
next prev parent reply other threads:[~2008-07-17 4:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-15 19:32 [GIT PATCH] rfkill fixes, set 2 Henrique de Moraes Holschuh
2008-07-15 19:32 ` [PATCH 1/4] rfkill: document rfkill_force_state as required Henrique de Moraes Holschuh
2008-07-19 12:34 ` Ivo van Doorn
2008-07-19 13:42 ` Henrique de Moraes Holschuh
2008-07-15 19:32 ` [PATCH 2/4] rfkill: fix led-trigger unregister order in error unwind Henrique de Moraes Holschuh
2008-07-19 12:35 ` Ivo van Doorn
2008-07-15 19:32 ` [PATCH 3/4] rfkill: document the rfkill struct locking Henrique de Moraes Holschuh
2008-07-19 12:39 ` Ivo van Doorn
2008-07-19 13:43 ` Henrique de Moraes Holschuh
2008-07-15 19:32 ` [PATCH 4/4] rfkill: mutex fixes Henrique de Moraes Holschuh
2008-07-17 4:56 ` Michael Buesch [this message]
2008-07-17 11:33 ` drago01
2008-07-17 12:10 ` Henrique de Moraes Holschuh
2008-07-19 12:47 ` Ivo van Doorn
2008-07-19 14:19 ` Henrique de Moraes Holschuh
2008-07-19 14:50 ` Ivo van Doorn
2008-07-19 14:51 ` Ivo van Doorn
2008-07-16 16:29 ` [GIT PATCH] rfkill fixes, set 2 Dan Williams
2008-07-17 11:54 ` Henrique de Moraes Holschuh
2008-07-17 21:56 ` [PATCH 5/4] rfkill: query EV_SW states when rfkill-input connects to a input device Henrique de Moraes Holschuh
2008-07-19 4:01 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807170656.37190.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=hmh@hmh.eng.br \
--cc=ivdoorn@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.