From: Paul Mundt <lethal@linux-sh.org>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH] sh: Add SuperH Mobile MSTPCR bits to clock framework
Date: Thu, 17 Jul 2008 22:41:21 +0000 [thread overview]
Message-ID: <20080717224121.GA17674@linux-sh.org> (raw)
In-Reply-To: <20080717095615.19566.83528.sendpatchset@rx1.opensource.se>
On Thu, Jul 17, 2008 at 06:56:15PM +0900, Magnus Damm wrote:
> +#define DECLARE_MSTPCRN(regnr, bitnr, bitstr) \
> +{ \
> + .name = "mstp" __stringify(regnr) bitstr, \
> + .arch_flags = bitnr, \
> + .ops = &sh7722_mstpcr ## regnr ## _clk_ops, \
> +}
> +
> +#define DECLARE_MSTPCR(regnr) \
> + DECLARE_MSTPCRN(regnr, 31, "31"), \
This looks a bit clumsy. Why can't you __stringify bitnr and paste that
against the stringified regnr? You may not be able to use the helper
macros directly, but you can certainly abuse the pre-processor in such a
way.
next prev parent reply other threads:[~2008-07-17 22:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-17 9:56 [PATCH] sh: Add SuperH Mobile MSTPCR bits to clock framework Magnus Damm
2008-07-17 22:41 ` Paul Mundt [this message]
2008-07-17 23:11 ` Paul Mundt
2008-07-18 1:14 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080717224121.GA17674@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.