From: Magnus Damm <magnus.damm@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus.damm@gmail.com>,
hjk@linutronix.de, gregkh@suse.de, akpm@linux-foundation.org
Subject: [PATCH 04/06] uio: Store struct uio_mem ptr in vma->vm_private_data
Date: Fri, 18 Jul 2008 14:04:35 +0900 [thread overview]
Message-ID: <20080718050435.16250.39097.sendpatchset@rx1.opensource.se> (raw)
In-Reply-To: <20080718050402.16250.25213.sendpatchset@rx1.opensource.se>
From: Magnus Damm <damm@igel.co.jp>
Store a struct uio_mem pointer in vma->vm_private_data. This improves
performance since it allows us to remove a call to uio_find_mem()
from uio_vma_fault(). This change also moves the vma_count member from
struct uio_device to struct uio_mem.
The VM_FAULT_SIGBUS error case in uio_vma_fault() case is simply
removed since we've verified the struct uio_mem pointer earlier when
setting up the vma->vm_private_data.
Signed-off-by: Magnus Damm <damm@igel.co.jp>
---
drivers/uio/uio.c | 17 ++++++-----------
include/linux/uio_driver.h | 1 +
2 files changed, 7 insertions(+), 11 deletions(-)
--- 0004/drivers/uio/uio.c
+++ work/drivers/uio/uio.c 2008-07-18 12:43:22.000000000 +0900
@@ -32,7 +32,6 @@ struct uio_device {
atomic_t event;
struct fasync_struct *async_queue;
wait_queue_head_t wait;
- int vma_count;
struct uio_info *info;
struct kobject *map_dir;
};
@@ -443,25 +442,21 @@ static struct uio_mem *uio_find_mem(stru
static void uio_vma_open(struct vm_area_struct *vma)
{
- struct uio_device *idev = vma->vm_private_data;
- idev->vma_count++;
+ struct uio_mem *imem = vma->vm_private_data;
+ imem->vma_count++;
}
static void uio_vma_close(struct vm_area_struct *vma)
{
- struct uio_device *idev = vma->vm_private_data;
- idev->vma_count--;
+ struct uio_mem *imem = vma->vm_private_data;
+ imem->vma_count--;
}
static int uio_vma_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
{
- struct uio_device *idev = vma->vm_private_data;
- struct uio_mem *imem = uio_find_mem(idev, vma);
+ struct uio_mem *imem = vma->vm_private_data;
struct page *page;
- if (!imem)
- return VM_FAULT_SIGBUS;
-
if (imem->memtype == UIO_MEM_LOGICAL)
page = virt_to_page(imem->addr);
else
@@ -521,7 +516,7 @@ static int uio_mmap(struct file *filep,
return ret;
}
- vma->vm_private_data = idev;
+ vma->vm_private_data = imem;
switch (imem->memtype) {
case UIO_MEM_PHYS:
--- 0001/include/linux/uio_driver.h
+++ work/include/linux/uio_driver.h 2008-07-18 12:43:22.000000000 +0900
@@ -34,6 +34,7 @@ struct uio_mem {
int memtype;
void __iomem *internal_addr;
struct uio_map *map;
+ int vma_count;
};
#define MAX_UIO_MAPS 5
next prev parent reply other threads:[~2008-07-18 5:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 5:04 [PATCH 00/06] uio: Various minor changes Magnus Damm
2008-07-18 5:04 ` [PATCH 01/06] uio: Use struct_uio_mem instead of index Magnus Damm
2008-07-18 5:04 ` [PATCH 02/06] uio: Pass struct uio_mem to mmap functions Magnus Damm
2008-07-18 5:04 ` [PATCH 03/06] uio: Remove vma->vm_private_data from uio_find_mem() Magnus Damm
2008-07-18 5:04 ` Magnus Damm [this message]
2008-07-18 5:04 ` [PATCH 05/06] uio: Remove redundant vma->vm_flags setup code Magnus Damm
2008-07-18 5:04 ` [PATCH 06/06] uio: Support multiple UIO_MEM_LOGICAL/VIRTUAL pages Magnus Damm
2008-07-18 15:46 ` [PATCH 00/06] uio: Various minor changes Hans J. Koch
2008-07-25 9:12 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080718050435.16250.39097.sendpatchset@rx1.opensource.se \
--to=magnus.damm@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=hjk@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.