All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>,
	Jesse Barnes <jbarnes@virtuousgeek.org>,
	linux-next@vger.kernel.org, Jeremy Fitzhardinge <jeremy@goop.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: linux-next: pci tree build failure
Date: Fri, 18 Jul 2008 09:53:22 +0200	[thread overview]
Message-ID: <20080718075322.GF6875@elte.hu> (raw)
In-Reply-To: <20080718160904.64541954.sfr@canb.auug.org.au>


* Stephen Rothwell <sfr@canb.auug.org.au> wrote:

> Hi Rafael,
> 
> On Fri, 18 Jul 2008 00:57:06 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> >
> > The patch is correct.
> 
> Thanks.

heh, i've done the exactly same change yesterday night, independently, 
in tip/xen-64bit - where this interaction originates from. (see below)

but i zapped it and took yours instead because yours came 19 hours 
earlier - i should have checked my mbox sooner ;)

Jeremy, is this change fine with you too?

( btw., could you please Cc: lkml to all patches? It's not like 
  linux-next is irrelevant to lkml - it's highly on topic in fact - and 
  what seems like future stuff today is an actuality tomorrow that 
  people might want to grep for. )

	Ingo

---------------------------->
commit dc860d89be3e640b98e9e202611466cc22575166
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu Jul 17 23:58:52 2008 +0200

    x86, xen: adopt suspend/resume API use
    
    the device_power_up()/device_resume() APIs got changed by:
    1eede070a5 "Introduce new top level suspend and hibernation callbacks".
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 drivers/xen/manage.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/xen/manage.c b/drivers/xen/manage.c
index 2bb268e..a5bc91a 100644
--- a/drivers/xen/manage.c
+++ b/drivers/xen/manage.c
@@ -63,7 +63,7 @@ static int xen_suspend(void *data)
 	gnttab_resume();
 	xen_mm_unpin_all();
 
-	device_power_up();
+	device_power_up(PMSG_RESUME);
 
 	if (!*cancelled) {
 		xen_irq_resume();
@@ -114,7 +114,7 @@ static void do_suspend(void)
 	} else
 		xenbus_suspend_cancel();
 
-	device_resume();
+	device_resume(PMSG_RESUME);
 
 	/* Make sure timer events get retriggered on all CPUs */
 	clock_was_set();

  reply	other threads:[~2008-07-18  7:53 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20080717130924.edd5a501.sfr@canb.auug.org.au>
2008-07-17 22:57 ` linux-next: pci tree build failure Rafael J. Wysocki
2008-07-18  6:09   ` Stephen Rothwell
2008-07-18  7:53     ` Ingo Molnar [this message]
2010-01-27  6:49 Stephen Rothwell
2010-01-27 17:31 ` Jesse Barnes
2010-01-28  6:14   ` Stephen Rothwell
  -- strict thread matches above, loose matches on Subject: below --
2010-01-18  8:40 Stephen Rothwell
2010-01-18 21:24 ` Rafael J. Wysocki
2010-01-19  2:35   ` Jesse Barnes
2010-01-19  3:19     ` Stephen Rothwell
2010-01-20  4:39 ` Jesse Barnes
2010-01-20  5:19   ` Stephen Rothwell
2010-01-04 22:55 Stephen Rothwell
2010-01-04 23:10 ` Matthew Wilcox
2010-01-04 23:48   ` Jesse Barnes
2010-01-05  3:41     ` Stephen Rothwell
2009-10-07  1:38 Stephen Rothwell
2009-10-07  1:45 ` Tejun Heo
2009-10-07 15:39   ` Jesse Barnes
2009-07-15  1:45 Stephen Rothwell
2009-07-15 16:09 ` Jesse Barnes
2009-07-15 23:46   ` Stephen Rothwell
2009-06-30  2:07 Stephen Rothwell
2009-06-30  2:13 ` Jesse Barnes
2009-06-30  2:24   ` Matthew Wilcox
2009-06-30 20:31     ` Jesse Barnes
2009-03-23  1:49 Stephen Rothwell
2009-03-25  1:21 ` Stephen Rothwell
2009-03-25  1:38   ` Jesse Barnes
2009-03-25  3:41     ` Stephen Rothwell
2009-03-25  4:30       ` Matthew Wilcox
2009-03-25 15:55         ` Jesse Barnes
2009-03-26  3:05           ` Stephen Rothwell
2009-03-26  3:37             ` Jesse Barnes
2009-03-26  4:54               ` Stephen Rothwell
2008-10-22  2:39 Stephen Rothwell
2008-10-22  3:47 ` Jesse Barnes
2008-10-16  3:41 Stephen Rothwell
2008-10-16  3:44 ` Benjamin Herrenschmidt
2008-10-16  4:23   ` Jesse Barnes
2008-10-16  4:28     ` Benjamin Herrenschmidt
2008-10-18 22:41       ` Jesse Barnes
2008-10-19  4:15         ` Stephen Rothwell
2008-10-19  4:30           ` Jesse Barnes
2008-07-08  1:40 Stephen Rothwell
2008-07-08 14:54 ` Rafael J. Wysocki
     [not found] <20080630142314.34654d3c.sfr@canb.auug.org.au>
2008-06-30 14:11 ` Alan Stern
2008-07-02  2:11   ` Jesse Barnes
2008-06-30  5:11 Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718075322.GF6875@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=jeremy@goop.org \
    --cc=linux-next@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=sfr@canb.auug.org.au \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.