All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Max Krasnyansky <maxk@qualcomm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org,
	dmitry.adamushko@gmail.com, a.p.zijlstra@chello.nl,
	rostedt@goodmis.org, vegard.nossum@gmail.com
Subject: Re: [PATCH] cpu hotplug: Make cpu_active_map synchronization dependency clear
Date: Fri, 18 Jul 2008 13:26:35 +0200	[thread overview]
Message-ID: <20080718112635.GA6875@elte.hu> (raw)
In-Reply-To: <1216180586-8313-1-git-send-email-maxk@qualcomm.com>


* Max Krasnyansky <maxk@qualcomm.com> wrote:

> This goes on top of the cpu_active_map (take 2) patch.

i've applied it to sched/devel. Note that checkpatch caught:

> +	/* Make sure the all cpus did the reschedule and are not
> +	 * using stale version of the cpu_active_map.
> +	 * This is not strictly necessary becuase stop_machine() 
> +	 * that we run down the line already provides the required 
> +	 * synchronization. But it's really a side effect and we do not 
> +	 * want to depend on the innards of the stop_machine here. */
> +	synchronize_sched();

this had both whitespace problems (trailing spaces) and basic formatting 
problems. I fixed these up.

	Ingo

  reply	other threads:[~2008-07-18 11:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  3:56 [PATCH] cpu hotplug: Make cpu_active_map synchronization dependency clear Max Krasnyansky
2008-07-18 11:26 ` Ingo Molnar [this message]
2008-07-18 12:03   ` Ingo Molnar
2008-07-22  4:07     ` Max Krasnyansky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080718112635.GA6875@elte.hu \
    --to=mingo@elte.hu \
    --cc=a.p.zijlstra@chello.nl \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxk@qualcomm.com \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@linux-foundation.org \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.