From: Ivo van Doorn <ivdoorn@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org,
rt2400-devel@lists.sourceforge.net,
Olivier Cornu <o.cornu@gmail.com>
Subject: Re: [PATCH 2/6] rt2x00: Fix EIFS timing value
Date: Fri, 18 Jul 2008 21:07:08 +0200 [thread overview]
Message-ID: <200807182107.08540.IvDoorn@gmail.com> (raw)
In-Reply-To: <1216406699.27738.42.camel@johannes.berg>
On Friday 18 July 2008, Johannes Berg wrote:
> On Fri, 2008-07-18 at 20:43 +0200, Ivo van Doorn wrote:
>
> > #define SHORT_PIFS ( SIFS + SHORT_SLOT_TIME )
> > #define DIFS ( PIFS + SLOT_TIME )
> > #define SHORT_DIFS ( SHORT_PIFS + SHORT_SLOT_TIME )
> > -#define EIFS ( SIFS + (8 * (IEEE80211_HEADER + ACK_SIZE)) )
> > +#define EIFS 364
>
> Haven't checked what it comes out to be, but it should be SIFS + DIFS +
> AckTxTime.
For normal slot time: 364
For short slot time: 342
So for normal slot time this would be correct, but it wouldn't for short slot time,
legacy driver seems to have hardcoded the value to 364. So for now I think it is
best to keep it hardcoded like that, and experiment a bit later to see what the
impact will for short slot time.
(Note that rt61/rt73 will use 364 as EIFS and always uses a short slot time)
Ivo
next prev parent reply other threads:[~2008-07-18 18:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-18 18:43 Please pull 'upstream' branch of rt2x00 Ivo van Doorn
2008-07-18 18:43 ` [PATCH 1/6] rt2x00: Remove duplicate declaration Ivo van Doorn
2008-07-18 18:43 ` [PATCH 2/6] rt2x00: Fix EIFS timing value Ivo van Doorn
2008-07-18 18:44 ` [PATCH 3/6] rt2x00: Support for large vendor requests Ivo van Doorn
2008-07-18 18:44 ` [PATCH 4/6] rt2x00: Large vendor requests for rt73usb firmware upload and Ivo van Doorn
2008-07-18 18:45 ` [PATCH 5/6] rt2x00: Fix the beacon length bug Ivo van Doorn
2008-07-18 18:45 ` [PATCH 6/6] rt2x00: Fix GCC warning because aifs is now unsigned Ivo van Doorn
2008-07-18 18:53 ` Johannes Berg
2008-07-18 19:16 ` Ivo van Doorn
2008-07-18 18:44 ` [PATCH 2/6] rt2x00: Fix EIFS timing value Johannes Berg
2008-07-18 19:07 ` Ivo van Doorn [this message]
2008-07-19 13:55 ` Please pull 'upstream' branch of rt2x00 Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807182107.08540.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=o.cornu@gmail.com \
--cc=rt2400-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.