From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KKEYz-0004Pl-Sl for mharc-grub-devel@gnu.org; Sat, 19 Jul 2008 11:41:37 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKEYx-0004OJ-RK for grub-devel@gnu.org; Sat, 19 Jul 2008 11:41:35 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKEYw-0004Mz-1l for grub-devel@gnu.org; Sat, 19 Jul 2008 11:41:35 -0400 Received: from [199.232.76.173] (port=44771 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKEYv-0004Ma-NT for grub-devel@gnu.org; Sat, 19 Jul 2008 11:41:33 -0400 Received: from aybabtu.com ([69.60.117.155]:35258) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KKEYv-0006wb-CC for grub-devel@gnu.org; Sat, 19 Jul 2008 11:41:33 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KKETM-00049E-Mm for grub-devel@gnu.org; Sat, 19 Jul 2008 17:35:49 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KKEY7-00071t-A9 for grub-devel@gnu.org; Sat, 19 Jul 2008 17:40:43 +0200 Date: Sat, 19 Jul 2008 17:40:43 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080719154043.GG23778@thorin> References: <20080717212227.GA11725@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080717212227.GA11725@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: menu loop (patch) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2008 15:41:36 -0000 On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > > Hello, Carles! Que n'és de petit el món ;-) > I'm a Grub user (thanks for your nice work!) and I always wanted to have > a menu that "loops". Like, if you press down and you are in the last > option it goes to the first one, and if you press up but you are int he > first option goes to the last. > > Attached comes a patch against revision 1718. > > Of course, feel free to comment anything about it. I'm open to change, > fix, etc. > > I also don't know if this functionality is not in Grub because you > thought that was better to not have this functionality. > > I've copied/change a few lines (after the patch, lines 425-428 are the > same than lines 347-350). I don't think that it's needed to refactor but > if you think so I can do it. I'm not sure if this is intentional. Size is not important in this part of the code, but in other UI menus (e.g. Iceweasel or GNOME) I notice this is not done. It could also be a nuissance for users who want to go rapidly to the top or bottom (sure, they can use PgUp/PgDn, but then aren't we making the behaviour of those keys inconsistent with arrows?). Also, if you (or anyone) can point to a "usability best practices" reference saying this has been carefuly analized and one of the options was found to be better, I think this would help us make a decision. What does everyone else think? Colin, does this affect your graphical menu work in some way? I suppose the same situation applies the same way to the upcoming new menu. Or perhaps this can be made more flexible and be toggled by some CSS magic? -- Robert Millan I know my rights; I want my phone call! What good is a phone call… if you are unable to speak? (as seen on /.)