From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KKG85-0006m6-M9 for mharc-grub-devel@gnu.org; Sat, 19 Jul 2008 13:21:57 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KKG83-0006lh-Qr for grub-devel@gnu.org; Sat, 19 Jul 2008 13:21:55 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KKG7z-0006kV-8f for grub-devel@gnu.org; Sat, 19 Jul 2008 13:21:55 -0400 Received: from [199.232.76.173] (port=44309 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KKG7z-0006kP-4u for grub-devel@gnu.org; Sat, 19 Jul 2008 13:21:51 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:42101 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KKG7x-00016i-Qh for grub-devel@gnu.org; Sat, 19 Jul 2008 13:21:50 -0400 Received: from pinux (unknown [77.210.79.62]) by mail.pina.cat (Postfix) with ESMTP id 2761C288FBA0F for ; Sat, 19 Jul 2008 19:21:40 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 2A0438C95; Sat, 19 Jul 2008 19:21:34 +0200 (CEST) Date: Sat, 19 Jul 2008 19:21:34 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080719172134.GA3760@pina.cat> References: <20080717212227.GA11725@pina.cat> <20080719154043.GG23778@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20080719154043.GG23778@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) Content-Transfer-Encoding: quoted-printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: menu loop (patch) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Jul 2008 17:21:56 -0000 Hello, On Jul/19/2008, Robert Millan wrote: > On Thu, Jul 17, 2008 at 11:22:27PM +0200, Carles Pina i Estany wrote: > >=20 > > Hello, >=20 > Carles! Que n'=E9s de petit el m=F3n ;-) exacte! :-) > > I'm a Grub user (thanks for your nice work!) and I always wanted to h= ave > > a menu that "loops". Like, if you press down and you are in the last > > option it goes to the first one, and if you press up but you are int = he > > first option goes to the last. > >=20 > > Attached comes a patch against revision 1718. > >=20 > > Of course, feel free to comment anything about it. I'm open to change= , > > fix, etc. > >=20 > > I also don't know if this functionality is not in Grub because you > > thought that was better to not have this functionality.=20 > >=20 > > I've copied/change a few lines (after the patch, lines 425-428 are th= e > > same than lines 347-350). I don't think that it's needed to refactor = but > > if you think so I can do it. >=20 > I'm not sure if this is intentional. Size is not important in this > part of the code, but in other UI menus (e.g. Iceweasel or GNOME) I fast check in KDE: it's looping Also, Iceweasel menus are looping here (maybe because it's executed in KDE and there is some GTK Widget with a different behaviour? I have no idea) > notice this is not done. It could also be a nuissance for users who > want to go rapidly to the top or bottom (sure, they can use PgUp/PgDn, > but then aren't we making the behaviour of those keys inconsistent > with arrows?). I would be glad to add some functionality for PgUp/PgDown and also for Home/End keys (I would do it today evening or tomorrow and send the patch). > Also, if you (or anyone) can point to a "usability best practices" > reference saying this has been carefuly analized and one of the > options was found to be better, I think this would help us make a > decision. I will also check tonight. My patch is based on two things: -what I was expecting as user (I always tried KeyUp to go to the end in Grub -but not Home/End/PgUp/PgDown) -what one non-IT workmate told me that it's annoying that he cannot press KeyUp to go to the last option. Thanks, we are in touch here :-) --=20 Carles Pina i Estany GPG id: 0x8CBDAE64 http://pinux.info Manresa - Barcelona