From: Ingo Molnar <mingo@elte.hu>
To: Zachary Amsden <zach@vmware.com>
Cc: Suresh Siddha <suresh.b.siddha@intel.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives
Date: Sat, 19 Jul 2008 23:43:29 +0200 [thread overview]
Message-ID: <20080719214329.GA836@elte.hu> (raw)
In-Reply-To: <1216424592.30348.33.camel@bodhitayantram.eng.vmware.com>
* Zachary Amsden <zach@vmware.com> wrote:
> On Fri, 2008-07-18 at 15:49 -0700, Suresh Siddha wrote:
>
> > > Thank you for cleaning this up Yinghai, but this really begs the
> > > question - is having write_atomic REALLY worthwhile?
> >
> > And this thread is about, Maciej's cleanup patch which removed
> > write_atomic completely :)
> >
> > Thanks to Maciej who posted this fix. It was on my todo list for
> > sometime now!
>
> Awesome! I just felt the need to use 'flaming crap' in a sentence
> today, and broken APICs seemed like an easy target. Glad to know it's
> gone.
it's gone, but without breaking or limiting old hardware: it's done by
moving the code into a quirk. And that's the general direction which we
want to take in such cases - move ugly non-standard stuff into
low-maintenance-overhead quirks.
Ingo
next prev parent reply other threads:[~2008-07-19 21:44 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 18:15 [PATCH] x86: APIC: Remove apic_write_around(); use alternatives Maciej W. Rozycki
2008-07-18 10:52 ` Ingo Molnar
2008-07-18 16:25 ` Yinghai Lu
2008-07-18 17:01 ` Yinghai Lu
2008-07-18 21:03 ` Ingo Molnar
2008-07-18 21:13 ` Yinghai Lu
2008-07-18 22:02 ` Maciej W. Rozycki
2008-07-18 22:42 ` Zachary Amsden
2008-07-18 22:49 ` Suresh Siddha
2008-07-18 22:51 ` Yinghai Lu
2008-07-18 23:00 ` Suresh Siddha
2008-07-18 23:04 ` Yinghai Lu
2008-07-18 23:18 ` Suresh Siddha
2008-07-19 21:49 ` Ingo Molnar
2008-07-19 21:53 ` Ingo Molnar
2008-07-20 12:08 ` Ingo Molnar
2008-07-20 15:04 ` Ingo Molnar
2008-07-21 17:59 ` Suresh Siddha
2008-07-22 13:24 ` Yong Wang
2008-07-22 13:48 ` Ingo Molnar
2008-07-18 23:43 ` Zachary Amsden
2008-07-19 21:43 ` Ingo Molnar [this message]
2008-07-18 22:58 ` Suresh Siddha
2008-07-19 21:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080719214329.GA836@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.