From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: introduce x86_ops
Date: Sun, 20 Jul 2008 09:21:02 +0200 [thread overview]
Message-ID: <20080720072102.GC32168@elte.hu> (raw)
In-Reply-To: <200807190207.26077.yhlu.kernel@gmail.com>
* Yinghai Lu <yhlu.kernel@gmail.com> wrote:
> Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
>
> ---
> arch/x86/kernel/e820.c | 9 +-------
> arch/x86/kernel/mpparse.c | 17 ++++------------
> arch/x86/kernel/setup.c | 4 +++
> arch/x86/kernel/visws_quirks.c | 42 +++++++++++++++++++----------------------
> arch/x86/mach-default/setup.c | 24 +++++++----------------
> include/asm-x86/setup.h | 18 ++++++++++-------
> 6 files changed, 50 insertions(+), 64 deletions(-)
> +extern struct x86_ops *x86_ops;
great cleanup!
one detail: i've renamed x86_ops to x86_quirks (and propagated the
rename into your subseqent patches as well), because this is really
something that is not used by normal hardware.
Ingo
prev parent reply other threads:[~2008-07-20 7:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-19 9:07 [PATCH] x86: introduce x86_ops Yinghai Lu
2008-07-19 9:16 ` Joerg Roedel
2008-07-19 9:19 ` Yinghai Lu
2008-07-19 9:36 ` Joerg Roedel
2008-07-20 1:01 ` [PATCH] x86: use x86_ops with numaq Yinghai Lu
2008-07-20 7:28 ` Ingo Molnar
2008-07-20 1:02 ` [PATCH] x86: add pre_time_init in x86_ops Yinghai Lu
2008-07-20 7:28 ` Ingo Molnar
2008-07-20 7:21 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720072102.GC32168@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.