From: Arjan van de Ven <arjan@infradead.org>
To: Neil Brown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
Simon Arlott <simon@fire.lp0.eu>,
Daniel Walker <dwalker@mvista.com>,
Rene Herman <rene.herman@keyaccess.nl>
Subject: Re: [patch 3/4] fastboot: make the raid autodetect code wait for all devices to init
Date: Sun, 20 Jul 2008 14:33:02 -0700 [thread overview]
Message-ID: <20080720143302.118bfac4@infradead.org> (raw)
In-Reply-To: <18564.4308.219240.133199@notabene.brown>
On Mon, 21 Jul 2008 14:30:12 +1000
Neil Brown <neilb@suse.de> wrote:
>
> > + while (driver_probe_done())
> > msleep(100);
>
> That's worse. Now it really looks like a boolean that is being used
> wrongly. It seems that driver_probe_done either returns 0 or -EBUSY,
> so I'd prefer
>
> > + while (driver_probe_done() < 0)
> > msleep(100);
>
> or even
ok I've done this one.
I'll be the first to say that this driver_probe_done() isn't very
elegant.. but it's out of my current scope to rewrite that whole
thing ... I'll leave that to GregKH.
--
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-07-21 4:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080720151140.4aa7c682@infradead.org>
2008-07-20 22:12 ` [patch 1/4] fastboot: make fastboot a config option Arjan van de Ven
2008-07-30 15:23 ` Randy Dunlap
2008-07-31 10:53 ` Ingo Molnar
2008-07-20 22:13 ` [patch 2/4] fastboot: retry mounting the root fs if we can't find init Arjan van de Ven
2008-07-21 1:35 ` Daniel Walker
2008-07-20 22:13 ` [patch 3/4] fastboot: make the raid autodetect code wait for all devices to init Arjan van de Ven
2008-07-20 23:06 ` Neil Brown
2008-07-20 23:12 ` david
2008-07-20 23:19 ` Arjan van de Ven
2008-07-20 23:31 ` Arjan van de Ven
2008-07-21 4:30 ` Neil Brown
2008-07-20 21:33 ` Arjan van de Ven [this message]
2008-07-21 11:34 ` martin f krafft
2008-07-21 23:24 ` Neil Brown
2008-07-22 10:36 ` martin f krafft
2008-07-20 22:14 ` [patch 4/4] fastboot: remove "wait for all devices before mounting root" delay Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720143302.118bfac4@infradead.org \
--to=arjan@infradead.org \
--cc=dwalker@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=rene.herman@keyaccess.nl \
--cc=simon@fire.lp0.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.