From: Nathan Lynch <ntl@pobox.com>
To: Sean MacLennan <smaclennan@pikatech.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] Don't panic when EEH_MAX_FAILS is exceeded
Date: Sun, 20 Jul 2008 15:17:08 -0500 [thread overview]
Message-ID: <20080720201708.GP9594@localdomain> (raw)
In-Reply-To: <20080720145858.5be92934@lappy.seanm.ca>
Sean MacLennan wrote:
> On Sun, 20 Jul 2008 11:28:36 -0700
> "Mike Mason" <mmlnx@us.ibm.com> wrote:
>
> > This patch changes the EEH_MAX_FAILS action from panic to printing an
> > error message. Panicking under under this condition is too harsh.
> > Although performance will be affected and the device may not recover,
> > the system is still running, which at the very least, should allow
> > for a more graceful shutdown. The panic() is now wrapped in a DEBUG
> > statement for development purposes. The patch also removes the
> > msleep() within a spinlock, which is not allowed.
>
> Why can you not msleep within a spinlock? And when was this change
> brought in?
Giving up the cpu while holding a spinlock risks locking up the system
in the worst case -- if another task tries to acquire the held lock it
can spin indefinitely.
next prev parent reply other threads:[~2008-07-20 20:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 18:28 [PATCH] Don't panic when EEH_MAX_FAILS is exceeded Mike Mason
2008-07-20 18:58 ` Sean MacLennan
2008-07-20 20:17 ` Nathan Lynch [this message]
2008-07-21 3:47 ` Sean MacLennan
2008-07-21 4:09 ` Stephen Rothwell
2008-07-21 15:04 ` Sean MacLennan
2008-07-20 20:33 ` Nathan Lynch
2008-07-20 23:19 ` Linas Vepstas
2008-07-21 16:40 ` Mike Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720201708.GP9594@localdomain \
--to=ntl@pobox.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.