All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Moore <paul.moore@hp.com>
To: Vesa-Matti J Kari <vmkari@cc.helsinki.fi>
Cc: Eric Paris <eparis@parisplace.org>,
	Stephen Smalley <sds@tycho.nsa.gov>,
	James Morris <jmorris@namei.org>,
	selinux@tycho.nsa.gov
Subject: Re: [patch] SELinux: trivial, unify iterator variable naming
Date: Sun, 20 Jul 2008 21:25:36 -0400	[thread overview]
Message-ID: <200807202125.36525.paul.moore@hp.com> (raw)
In-Reply-To: <Pine.LNX.4.64L.0807210043160.7451@ruuvi.it.helsinki.fi>

On Sunday 20 July 2008 5:46:52 pm Vesa-Matti J Kari wrote:
> Hello,
>
> Renamed iterators "idx" and "iter" to "i", to be in harmony
> with the old unwritten C convention, and with the rest of the code.
>
> Signed-off-by: Vesa-Matti Kari <vmkari@cc.helsinki.fi>

Normally I like janitorial fixes such as whitespace cleanups, spelling 
corrections, etc.  However, these three patches seem a bit silly to me 
simply changing a variable name from "idx" to "i" and not adding any 
real value to the code.  If it were up to me alone, I would say "NO", 
but if everyone else agrees they are worthwhile I won't to stand in the 
way.

-- 
paul moore
linux @ hp

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  reply	other threads:[~2008-07-21  1:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-20 21:46 [patch] SELinux: trivial, unify iterator variable naming Vesa-Matti J Kari
2008-07-21  1:25 ` Paul Moore [this message]
2008-07-21  8:08   ` Vesa-Matti J Kari
2008-07-21 12:24     ` Paul Moore
2008-07-21 13:08       ` Vesa-Matti J Kari
2008-07-21 13:38         ` Paul Moore
2008-07-22 18:21           ` Vesa-Matti J Kari
2008-07-23  3:10             ` Paul Moore
2008-07-30  2:47           ` Russell Coker
2008-07-30 15:22             ` Paul Moore
2008-07-30 16:04               ` Vesa-Matti J Kari

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200807202125.36525.paul.moore@hp.com \
    --to=paul.moore@hp.com \
    --cc=eparis@parisplace.org \
    --cc=jmorris@namei.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    --cc=vmkari@cc.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.