From: Petr Baudis <pasky@suse.cz>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Steve Frécinaux" <code@istique.net>, git@vger.kernel.org
Subject: Re: [PATCH] Add a notice to the doc of git-ls-tree.
Date: Mon, 21 Jul 2008 01:39:56 +0200 [thread overview]
Message-ID: <20080720233956.GH10151@machine.or.cz> (raw)
In-Reply-To: <7vy73w16nj.fsf@gitster.siamese.dyndns.org>
On Sun, Jul 20, 2008 at 04:24:00PM -0700, Junio C Hamano wrote:
> Petr Baudis <pasky@suse.cz> writes:
>
> > I think that ls-tree simply shouldn't auto-fill its pathspec based on
> > current prefix in case no pathspec was supplied. Patch to follow.
>
> Have you dug the list archive from mid-to-late December 2005 that prompted
> the current behaviour (and introduction of --full-name)? I haven't. A
> change to always do the --full-name can only be justified by doing so and
> rehashing the issues.
>
> On the other hand, "fix" is welcome.
You are right, now that I understand the issue better, there's no good
fix for this except perhaps introducing --no-prefix, which is not my
itch to scratch. Here's my original wording improvement:
Note that if you are within a subdirectory of your working copy,
'git ls-tree' will automatically prepend the subdirectory prefix
to the specified paths, and assume the prefix specified in case
no paths were given - no matter what the tree object is! Thus,
within a subdirectory, 'git ls-tree' behaves as expected only
when run on a root tree object.
--
Petr "Pasky" Baudis
As in certain cults it is possible to kill a process if you know
its true name. -- Ken Thompson and Dennis M. Ritchie
next prev parent reply other threads:[~2008-07-20 23:41 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-20 22:25 [PATCH] Add a notice to the doc of git-ls-tree Steve Frécinaux
2008-07-20 23:08 ` Petr Baudis
2008-07-20 23:22 ` Steve Frécinaux
2008-07-20 23:24 ` Junio C Hamano
2008-07-20 23:39 ` Petr Baudis [this message]
2008-07-21 7:56 ` [PATCH] Documentation/git-ls-tree.txt: Add a caveat about prefixing pathspec Petr Baudis
2008-07-21 8:00 ` Junio C Hamano
2008-07-21 21:04 ` Petr Baudis
2008-07-22 0:32 ` Junio C Hamano
2008-07-22 22:47 ` Petr Baudis
2008-07-28 0:46 ` Petr Baudis
2008-07-28 1:26 ` Junio C Hamano
2008-07-28 9:23 ` Junio C Hamano
2008-07-21 8:45 ` Steve Frécinaux
2008-07-20 23:53 ` [PATCH] Add a notice to the doc of git-ls-tree Junio C Hamano
2008-07-21 0:08 ` Petr Baudis
2008-07-21 0:14 ` Junio C Hamano
2008-07-21 0:22 ` Petr Baudis
2008-07-21 4:28 ` Junio C Hamano
2008-07-21 7:47 ` Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720233956.GH10151@machine.or.cz \
--to=pasky@suse.cz \
--cc=code@istique.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.