From: Chirag Jog <chirag@linux.vnet.ibm.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linux-rt-users@vger.kernel.org,
Josh Triplett <josht@linux.vnet.ibm.com>,
Steven Rostedt <rostedt@goodmis.org>,
linuxppc-dev@ozlabs.org, Nivedita Singhvi <niv@us.ibm.com>,
"Timothy R. Chavez" <tim.chavez@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
paulmck@linux.vnet.ibm.com, linux.kernel@vger.kernel.org
Subject: Re: [PATCH][RT][PPC64] Fix preempt unsafe paths accessing per_cpu variables
Date: Mon, 21 Jul 2008 15:53:39 +0530 [thread overview]
Message-ID: <20080721102339.GR20277@linux.vnet.ibm.com> (raw)
In-Reply-To: <1216418730.7740.451.camel@pasglop>
Hi Benjamin
* Benjamin Herrenschmidt <benh@kernel.crashing.org> [2008-07-19 08:05:30]:
>
> > With the original patch, the pending batch does get flushed
> > in a non-preemptable region.
> > I am resending the original with just adding the necesary comments.
>
> Your comment isn't what I meant. What I meant is that if the process
> is context switched while walking the page tables, the low level powerpc
> context switch code should also perform a ???__flush_tlb_pending.
Sorry, I misunderstood.
The powerpc context switch code does perform a __flush_tlb_pending.
Here is the patch
http://marc.info/?l=linux-kernel&m=119752629222720&w=2
> BTW. Is the pte_lock also not a real spinlock anymore ? That may break
> other assumptions the powerpc mm code is doing.
pte_lock is a not a real spinlock anymore.
> This -rt stuff is just too scary, it changes some fundamental semantics
> of the spinlocks. yuck.
>
> Ben.
>
>
next prev parent reply other threads:[~2008-07-21 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-09 16:05 [PATCH][RT][PPC64] Fix preempt unsafe paths accessing per_cpu variables Chirag Jog
2008-07-09 16:05 ` Chirag Jog
2008-07-11 8:19 ` Sebastien Dugue
2008-07-11 8:19 ` Sebastien Dugue
2008-07-15 1:32 ` Benjamin Herrenschmidt
2008-07-15 1:32 ` Benjamin Herrenschmidt
2008-07-17 12:56 ` Chirag Jog
2008-07-17 12:56 ` Chirag Jog
2008-07-17 20:14 ` Benjamin Herrenschmidt
2008-07-17 20:14 ` Benjamin Herrenschmidt
2008-07-18 10:11 ` Chirag Jog
2008-07-18 10:11 ` Chirag Jog
2008-07-18 22:05 ` Benjamin Herrenschmidt
2008-07-18 22:05 ` Benjamin Herrenschmidt
2008-07-19 1:26 ` Steven Rostedt
2008-07-19 1:26 ` Steven Rostedt
2008-07-19 3:53 ` Benjamin Herrenschmidt
2008-07-19 3:53 ` Benjamin Herrenschmidt
2008-07-21 10:23 ` Chirag Jog [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-07-09 15:33 Chirag Jog
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721102339.GR20277@linux.vnet.ibm.com \
--to=chirag@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=josht@linux.vnet.ibm.com \
--cc=linux-rt-users@vger.kernel.org \
--cc=linux.kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=tim.chavez@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.