From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754918AbYGUNYp (ORCPT ); Mon, 21 Jul 2008 09:24:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751989AbYGUNYi (ORCPT ); Mon, 21 Jul 2008 09:24:38 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:59390 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752033AbYGUNYi (ORCPT ); Mon, 21 Jul 2008 09:24:38 -0400 Date: Mon, 21 Jul 2008 14:24:29 +0100 From: Al Viro To: Cyrill Gorcunov Cc: Li Zefan , Andrew Morton , Pekka Enberg , LKML Subject: Re: [PATCH] vfs: use kstrdup() and check failing allocation Message-ID: <20080721132429.GE28946@ZenIV.linux.org.uk> References: <48845FAC.9070500@cn.fujitsu.com> <20080721101623.GB7694@lenovo> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080721101623.GB7694@lenovo> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 21, 2008 at 02:16:23PM +0400, Cyrill Gorcunov wrote: > [Li Zefan - Mon, Jul 21, 2008 at 06:06:36PM +0800] > | - use kstrdup() instead of kmalloc() + memcpy() > | - return NULL if allocating ->mnt_devname failed > | - mnt_devname should be const > | > | Signed-off-by: Li Zefan > | --- > | > | Andrew, please drop vfs-use-kstrdup.patch > | > | --- > > Thanks Li. I think Al will be fine with this version. > > So if you needed: > Acked-by: Cyrill Gorcunov Applied.