From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andi Kleen <andi@firstfloor.org>,
torvalds@osdl.org, linux-acpi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Please pull ACPI tree
Date: Mon, 21 Jul 2008 17:09:21 +0200 [thread overview]
Message-ID: <20080721150921.GA29543@basil.nowhere.org> (raw)
In-Reply-To: <20080721142343.GA11345@elte.hu>
On Mon, Jul 21, 2008 at 04:23:43PM +0200, Ingo Molnar wrote:
>
> * Andi Kleen <andi@firstfloor.org> wrote:
>
> > This reverts some double commits and a trouble some FADT patch.
>
> > Andi Kleen (4):
> > Revert "dock: bay: Don't call acpi_walk_namespace() when ACPI is disabled."
>
> in that commit log you say:
>
> Revert "dock: bay: Don't call acpi_walk_namespace() when ACPI is disabled."
> Revert double commit by mistake. Noticed by Thomas Gleixner.
>
> it wasnt just "noticed" by Thomas, he sent a reverter patch with commit
> message and patch included. Why didnt you simply apply the patch from
> Thomas?
Of course so that you have something to complain about. I know
that is your favorite pastime in the last months, so I didn't want to deny
you the fun.
Seriously, typing in git revert is the way to apply a revert.
I could have cut'n'pasted his commit message, but it didn't seem
to make much difference.
-Andi (who is amazed he has to write emails on trivialities like this)
prev parent reply other threads:[~2008-07-21 15:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 11:43 Please pull ACPI tree Andi Kleen
2008-07-21 14:23 ` Ingo Molnar
2008-07-21 15:09 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721150921.GA29543@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.