From: Scott Wood <scottwood@freescale.com>
To: Dave Jones <davej@redhat.com>,
Kumar Gala <galak@kernel.crashing.org>,
linuxppc-dev@ozlabs.org, akpm@linux-foundation.org,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET
Date: Mon, 21 Jul 2008 11:13:07 -0500 [thread overview]
Message-ID: <20080721161307.GC13185@loki.buserror.net> (raw)
In-Reply-To: <20080716215745.GA17093@redhat.com>
On Wed, Jul 16, 2008 at 05:57:45PM -0400, Dave Jones wrote:
> On Wed, Jul 16, 2008 at 04:47:23PM -0500, Scott Wood wrote:
> > On Wed, Jul 16, 2008 at 08:39:12AM -0500, Kumar Gala wrote:
> > > If we don't enable FS_ENET we get build issues:
> > >
> > > arch/powerpc/platforms/built-in.o: In function `ep8248e_mdio_probe':
> > > arch/powerpc/platforms/82xx/ep8248e.c:129: undefined reference to `alloc_mdio_bitbang'
> > > arch/powerpc/platforms/82xx/ep8248e.c:143: undefined reference to `mdiobus_register'
> >
> > How is this possible? CONFIG_EP8248E selects CONFIG_MDIO_BITBANG.
>
> If CONFIG_PHYLIB=m however, that doesn't make any difference, because
> vmlinuz is trying to use a symbol which now lives in a module.
Yuck. If FOO selects BAR, and FOO is 'y', then BAR should be 'y', not 'm'.
If BAR depends on other symbols that are 'm', they should be changed to 'y'.
-Scott
next prev parent reply other threads:[~2008-07-21 16:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 13:39 [PATCH] powerpc/ep8248e: Fix compile problem if !CONFIG_FS_ENET Kumar Gala
2008-07-16 13:39 ` Kumar Gala
2008-07-16 21:47 ` Scott Wood
2008-07-16 21:47 ` Scott Wood
2008-07-16 21:57 ` Dave Jones
2008-07-16 21:57 ` Dave Jones
2008-07-16 22:10 ` Kumar Gala
2008-07-16 22:19 ` Dave Jones
2008-07-16 22:55 ` Kumar Gala
2008-07-21 16:14 ` Scott Wood
2008-07-21 16:14 ` Scott Wood
2008-07-16 22:23 ` Kumar Gala
2008-07-16 22:23 ` Kumar Gala
2008-07-21 16:13 ` Scott Wood [this message]
2008-07-16 22:01 ` Kumar Gala
2008-07-16 22:01 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721161307.GC13185@loki.buserror.net \
--to=scottwood@freescale.com \
--cc=akpm@linux-foundation.org \
--cc=davej@redhat.com \
--cc=galak@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.