From: Dave Jones <davej@redhat.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Fix serial_txx9 compile.
Date: Mon, 21 Jul 2008 18:27:02 -0400 [thread overview]
Message-ID: <20080721222702.GA19033@redhat.com> (raw)
In-Reply-To: <20080721230028.1c7020c9@lxorguk.ukuu.org.uk>
On Mon, Jul 21, 2008 at 11:00:28PM +0100, Alan Cox wrote:
> On Mon, 21 Jul 2008 17:16:59 -0400
> Dave Jones <davej@redhat.com> wrote:
>
> > drivers/serial/serial_txx9.c: In function 'receive_chars':
> > drivers/serial/serial_txx9.c:275: error: 'struct uart_info' has no member named 'tty'
>
> Already fixed ages ago. Its in a patch that didn't get to Linus yet - see
> the linux-next tree for the stuff pending.
Odd. This breakage happened with the merge in -git8
Why didn't the associated fixes go along with that merge ?
If it was fixed ages ago, that implies we knowingly merged broken code,
which seems suboptimal. If nothing else, we're breaking bisectability
by merging in two batches.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-07-21 22:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-21 21:16 Fix serial_txx9 compile Dave Jones
2008-07-21 22:00 ` Alan Cox
2008-07-21 22:27 ` Dave Jones [this message]
2008-07-21 22:34 ` Alan Cox
2008-07-21 22:13 ` Fix icom serial compile Dave Jones
2008-07-21 22:07 ` Alan Cox
2008-07-22 1:25 ` Stephen Rothwell
2008-07-22 2:05 ` Alan Cox
2008-07-22 2:41 ` Dave Jones
2008-07-22 10:46 ` Alan Cox
2008-07-22 1:56 ` Paul Mackerras
2008-07-22 2:06 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080721222702.GA19033@redhat.com \
--to=davej@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.