From: Ivo van Doorn <ivdoorn@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: John Linville <linville@tuxdriver.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 6/6] rfkill: yet more minor kernel-doc fixes
Date: Tue, 22 Jul 2008 19:11:32 +0200 [thread overview]
Message-ID: <200807221911.32602.IvDoorn@gmail.com> (raw)
In-Reply-To: <1216685902-9373-7-git-send-email-hmh@hmh.eng.br>
On Tuesday 22 July 2008, Henrique de Moraes Holschuh wrote:
> For some stupid reason, I sent and old version of the patch minor kernel
> doc-fix patch, and it got merged before I noticed the problem. This is an
> incremental fix on top.
>
> Signed-off-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
> Cc: Ivo van Doorn <IvDoorn@gmail.com>
Acked-by: Ivo van Doorn <IvDoorn@gmail.com>
> ---
> net/rfkill/rfkill.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/net/rfkill/rfkill.c b/net/rfkill/rfkill.c
> index ac205ec..c6f2f38 100644
> --- a/net/rfkill/rfkill.c
> +++ b/net/rfkill/rfkill.c
> @@ -130,7 +130,6 @@ static void update_rfkill_state(struct rfkill *rfkill)
>
> /**
> * rfkill_toggle_radio - wrapper for toggle_radio hook
> - *
> * @rfkill: the rfkill struct to use
> * @force: calls toggle_radio even if cache says it is not needed,
> * and also makes sure notifications of the state will be
> @@ -141,8 +140,8 @@ static void update_rfkill_state(struct rfkill *rfkill)
> * calls and handling all the red tape such as issuing notifications
> * if the call is successful.
> *
> - * Note that @force cannot override a (possibly cached) state of
> - * RFKILL_STATE_HARD_BLOCKED. Any device making use of
> + * Note that the @force parameter cannot override a (possibly cached)
> + * state of RFKILL_STATE_HARD_BLOCKED. Any device making use of
> * RFKILL_STATE_HARD_BLOCKED implements either get_state() or
> * rfkill_force_state(), so the cache either is bypassed or valid.
> *
> @@ -200,12 +199,12 @@ static int rfkill_toggle_radio(struct rfkill *rfkill,
>
> /**
> * rfkill_switch_all - Toggle state of all switches of given type
> - * @type: type of interfaces to be affeceted
> + * @type: type of interfaces to be affected
> * @state: the new state
> *
> - * This function toggles state of all switches of given type unless
> - * a specific switch is claimed by userspace in which case it is
> - * left alone.
> + * This function toggles the state of all switches of given type,
> + * unless a specific switch is claimed by userspace (in which case,
> + * that switch is left alone).
> */
> void rfkill_switch_all(enum rfkill_type type, enum rfkill_state state)
> {
> @@ -540,9 +539,10 @@ static void rfkill_remove_switch(struct rfkill *rfkill)
> * @type: type of the switch (RFKILL_TYPE_*)
> *
> * This function should be called by the network driver when it needs
> - * rfkill structure. Once the structure is allocated the driver shoud
> - * finish its initialization by setting name, private data, enable_radio
> + * rfkill structure. Once the structure is allocated the driver should
> + * finish its initialization by setting the name, private data, enable_radio
> * and disable_radio methods and then register it with rfkill_register().
> + *
> * NOTE: If registration fails the structure shoudl be freed by calling
> * rfkill_free() otherwise rfkill_unregister() should be used.
> */
> @@ -574,7 +574,7 @@ EXPORT_SYMBOL(rfkill_allocate);
> * rfkill_free - Mark rfkill structure for deletion
> * @rfkill: rfkill structure to be destroyed
> *
> - * Decrements reference count of rfkill structure so it is destroyed.
> + * Decrements reference count of the rfkill structure so it is destroyed.
> * Note that rfkill_free() should _not_ be called after rfkill_unregister().
> */
> void rfkill_free(struct rfkill *rfkill)
next prev parent reply other threads:[~2008-07-22 16:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-22 0:18 [GIT PATCH] rfkill fixes, set 2, v2 Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 1/6] rfkill: document rfkill_force_state as required (v2) Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 2/6] rfkill: fix led-trigger unregister order in error unwind Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 3/6] rfkill: document the rfkill struct locking (v2) Henrique de Moraes Holschuh
2008-07-22 17:11 ` Ivo van Doorn
2008-07-22 0:18 ` [PATCH 4/6] rfkill: mutex fixes Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 5/6] rfkill: query EV_SW states when rfkill-input (re)?connects to a input device Henrique de Moraes Holschuh
2008-07-22 13:57 ` Dmitry Torokhov
2008-07-22 17:11 ` Ivo van Doorn
2008-07-29 20:53 ` John W. Linville
2008-07-30 1:30 ` Dmitry Torokhov
2008-07-30 3:39 ` Henrique de Moraes Holschuh
2008-07-30 4:07 ` Henrique de Moraes Holschuh
2008-07-31 13:53 ` [PATCH] " Henrique de Moraes Holschuh
2008-07-31 14:38 ` Ivo van Doorn
2008-07-31 14:22 ` Henrique de Moraes Holschuh
2008-07-22 0:18 ` [PATCH 6/6] rfkill: yet more minor kernel-doc fixes Henrique de Moraes Holschuh
2008-07-22 17:11 ` Ivo van Doorn [this message]
2008-07-22 17:11 ` [GIT PATCH] rfkill fixes, set 2, v2 Ivo van Doorn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807221911.32602.IvDoorn@gmail.com \
--to=ivdoorn@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.