latest tree build failure -- cpm uart & gpio

All of lore.kernel.org
 help / color / mirror / Atom feed

* latest tree build failure -- cpm uart & gpio
@ 2008-07-22 13:54 ` Kumar Gala
  0 siblings, 0 replies; 13+ messages in thread
From: Kumar Gala @ 2008-07-22 13:54 UTC (permalink / raw)
  To: linuxppc-dev list; +Cc: Linux Kernel list, Alan Cox

can someone look at the following compile failure in linus's tree.   
I'm guessing part of this has to do with Alan's tty changes (and might  
already be addressed?).

include/asm-generic/gpio.h:131: error: implicit declaration of  
function 'gpio_get_value'
include/asm-generic/gpio.h:137: error: implicit declaration of  
function 'gpio_set_value'
make[4]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
drivers/serial/cpm_uart/cpm_uart_core.c:212: error: 'struct uart_info'  
has no member named 'tty'
make[4]: *** [drivers/serial/cpm_uart/cpm_uart_core.o] Error 1
make[3]: *** [drivers/serial/cpm_uart] Error 2
make[3]: *** [drivers/net/fs_enet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** [drivers/serial] Error 2
make[1]: *** [drivers] Error 2
make: *** [sub-make] Error 2

- k

^ permalink raw reply	[flat|nested] 13+ messages in thread

* latest tree build failure -- cpm uart & gpio
@ 2008-07-22 13:54 ` Kumar Gala
  0 siblings, 0 replies; 13+ messages in thread
From: Kumar Gala @ 2008-07-22 13:54 UTC (permalink / raw)
  To: linuxppc-dev list; +Cc: Alan Cox, Linux Kernel list

can someone look at the following compile failure in linus's tree.   
I'm guessing part of this has to do with Alan's tty changes (and might  
already be addressed?).

include/asm-generic/gpio.h:131: error: implicit declaration of  
function 'gpio_get_value'
include/asm-generic/gpio.h:137: error: implicit declaration of  
function 'gpio_set_value'
make[4]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
drivers/serial/cpm_uart/cpm_uart_core.c:212: error: 'struct uart_info'  
has no member named 'tty'
make[4]: *** [drivers/serial/cpm_uart/cpm_uart_core.o] Error 1
make[3]: *** [drivers/serial/cpm_uart] Error 2
make[3]: *** [drivers/net/fs_enet] Error 2
make[2]: *** [drivers/net] Error 2
make[2]: *** [drivers/serial] Error 2
make[1]: *** [drivers] Error 2
make: *** [sub-make] Error 2

- k

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 13:54 ` Kumar Gala
  (?)
@ 2008-07-22 13:52 ` Alan Cox
  -1 siblings, 0 replies; 13+ messages in thread
From: Alan Cox @ 2008-07-22 13:52 UTC (permalink / raw)
  To: Kumar Gala; +Cc: linuxppc-dev list, Linux Kernel list

On Tue, 22 Jul 2008 08:54:16 -0500
Kumar Gala <kumar.gala@freescale.com> wrote:

> can someone look at the following compile failure in linus's tree.   
> I'm guessing part of this has to do with Alan's tty changes (and might  
> already be addressed?).
> 
> include/asm-generic/gpio.h:131: error: implicit declaration of  
> function 'gpio_get_value'
> include/asm-generic/gpio.h:137: error: implicit declaration of  
> function 'gpio_set_value'

These are not

> make[4]: *** [drivers/net/fs_enet/fs_enet-main.o] Error 1
> drivers/serial/cpm_uart/cpm_uart_core.c:212: error: 'struct uart_info'  
> has no member named 'tty'

That one is and hasn't been addressed so I wil do it right now.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 13:54 ` Kumar Gala
@ 2008-07-22 14:53   ` Anton Vorontsov
  -1 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 14:53 UTC (permalink / raw)
  To: Kumar Gala; +Cc: David Brownell, linuxppc-dev list, Linux Kernel list, Alan Cox

On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> can someone look at the following compile failure in linus's tree.  I'm 
> guessing part of this has to do with Alan's tty changes (and might  
> already be addressed?).
>
> include/asm-generic/gpio.h:131: error: implicit declaration of function 
> 'gpio_get_value'
> include/asm-generic/gpio.h:137: error: implicit declaration of function 
> 'gpio_set_value'

I think this patch should help:

[OF] of_gpio: should use new <linux/gpio.h> header
http://patchwork.ozlabs.org/linuxppc/patch?id=18750

David, can you please Ack it? See Benjamin's mail:
http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
@ 2008-07-22 14:53   ` Anton Vorontsov
  0 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 14:53 UTC (permalink / raw)
  To: Kumar Gala
  Cc: linuxppc-dev list, Linux Kernel list, Alan Cox,
	Benjamin Herrenschmidt, David Brownell

On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> can someone look at the following compile failure in linus's tree.  I'm 
> guessing part of this has to do with Alan's tty changes (and might  
> already be addressed?).
>
> include/asm-generic/gpio.h:131: error: implicit declaration of function 
> 'gpio_get_value'
> include/asm-generic/gpio.h:137: error: implicit declaration of function 
> 'gpio_set_value'

I think this patch should help:

[OF] of_gpio: should use new <linux/gpio.h> header
http://patchwork.ozlabs.org/linuxppc/patch?id=18750

David, can you please Ack it? See Benjamin's mail:
http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 14:53   ` Anton Vorontsov
@ 2008-07-22 19:33     ` David Brownell
  -1 siblings, 0 replies; 13+ messages in thread
From: David Brownell @ 2008-07-22 19:33 UTC (permalink / raw)
  To: avorontsov; +Cc: linuxppc-dev list, Kumar Gala, Linux Kernel list, Alan Cox

On Tuesday 22 July 2008, Anton Vorontsov wrote:
> On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > can someone look at the following compile failure in linus's tree.  I'm 
> > guessing part of this has to do with Alan's tty changes (and might  
> > already be addressed?).
> >
> > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > 'gpio_get_value'
> > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > 'gpio_set_value'
> 
> I think this patch should help:
> 
> [OF] of_gpio: should use new <linux/gpio.h> header
> http://patchwork.ozlabs.org/linuxppc/patch?id=18750

Is that confirmed as fixing this, vs just being the Right Thing To Do?

 
> David, can you please Ack it? See Benjamin's mail:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html

If you like ... but this is an OF-specific change, making
it conform with the interface spec, so I wouldn't expect
this to need more approvals than it's already got.

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


> 
> -- 
> Anton Vorontsov
> email: cbouatmailru@gmail.com
> irc://irc.freenode.net/bd2
> 

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
@ 2008-07-22 19:33     ` David Brownell
  0 siblings, 0 replies; 13+ messages in thread
From: David Brownell @ 2008-07-22 19:33 UTC (permalink / raw)
  To: avorontsov
  Cc: Kumar Gala, linuxppc-dev list, Linux Kernel list, Alan Cox,
	Benjamin Herrenschmidt

On Tuesday 22 July 2008, Anton Vorontsov wrote:
> On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > can someone look at the following compile failure in linus's tree.  I'm 
> > guessing part of this has to do with Alan's tty changes (and might  
> > already be addressed?).
> >
> > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > 'gpio_get_value'
> > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > 'gpio_set_value'
> 
> I think this patch should help:
> 
> [OF] of_gpio: should use new <linux/gpio.h> header
> http://patchwork.ozlabs.org/linuxppc/patch?id=18750

Is that confirmed as fixing this, vs just being the Right Thing To Do?

 
> David, can you please Ack it? See Benjamin's mail:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html

If you like ... but this is an OF-specific change, making
it conform with the interface spec, so I wouldn't expect
this to need more approvals than it's already got.

Acked-by: David Brownell <dbrownell@users.sourceforge.net>


> 
> -- 
> Anton Vorontsov
> email: cbouatmailru@gmail.com
> irc://irc.freenode.net/bd2
> 



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 19:33     ` David Brownell
@ 2008-07-22 20:48       ` Anton Vorontsov
  -1 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 20:48 UTC (permalink / raw)
  To: David Brownell; +Cc: linuxppc-dev list, Kumar Gala, Linux Kernel list, Alan Cox

On Tue, Jul 22, 2008 at 12:33:16PM -0700, David Brownell wrote:
> On Tuesday 22 July 2008, Anton Vorontsov wrote:
> > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > > can someone look at the following compile failure in linus's tree.  I'm 
> > > guessing part of this has to do with Alan's tty changes (and might  
> > > already be addressed?).
> > >
> > > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > > 'gpio_get_value'
> > > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > > 'gpio_set_value'
> > 
> > I think this patch should help:
> > 
> > [OF] of_gpio: should use new <linux/gpio.h> header
> > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> 
> Is that confirmed as fixing this, vs just being the Right Thing To Do?

Just applied the patch locally and the issue is not reproducible
anymore.

> > David, can you please Ack it? See Benjamin's mail:
> > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> 
> If you like ... but this is an OF-specific change, making
> it conform with the interface spec, so I wouldn't expect
> this to need more approvals than it's already got.
> 
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>

Thanks.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
@ 2008-07-22 20:48       ` Anton Vorontsov
  0 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 20:48 UTC (permalink / raw)
  To: David Brownell
  Cc: Kumar Gala, linuxppc-dev list, Linux Kernel list, Alan Cox,
	Benjamin Herrenschmidt

On Tue, Jul 22, 2008 at 12:33:16PM -0700, David Brownell wrote:
> On Tuesday 22 July 2008, Anton Vorontsov wrote:
> > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > > can someone look at the following compile failure in linus's tree.  I'm 
> > > guessing part of this has to do with Alan's tty changes (and might  
> > > already be addressed?).
> > >
> > > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > > 'gpio_get_value'
> > > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > > 'gpio_set_value'
> > 
> > I think this patch should help:
> > 
> > [OF] of_gpio: should use new <linux/gpio.h> header
> > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> 
> Is that confirmed as fixing this, vs just being the Right Thing To Do?

Just applied the patch locally and the issue is not reproducible
anymore.

> > David, can you please Ack it? See Benjamin's mail:
> > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> 
> If you like ... but this is an OF-specific change, making
> it conform with the interface spec, so I wouldn't expect
> this to need more approvals than it's already got.
> 
> Acked-by: David Brownell <dbrownell@users.sourceforge.net>

Thanks.

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 14:53   ` Anton Vorontsov
@ 2008-07-22 22:05     ` Benjamin Herrenschmidt
  -1 siblings, 0 replies; 13+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-22 22:05 UTC (permalink / raw)
  To: avorontsov
  Cc: David Brownell, linuxppc-dev list, Kumar Gala, Linux Kernel list,
	Alan Cox

On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
> On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > can someone look at the following compile failure in linus's tree.  I'm 
> > guessing part of this has to do with Alan's tty changes (and might  
> > already be addressed?).
> >
> > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > 'gpio_get_value'
> > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > 'gpio_set_value'
> 
> I think this patch should help:
> 
> [OF] of_gpio: should use new <linux/gpio.h> header
> http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> 
> David, can you please Ack it? See Benjamin's mail:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> 

Hrm.. I though I had that one in my latest batch. In fact, I just
checked and it got merged.

Ben.

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
@ 2008-07-22 22:05     ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 13+ messages in thread
From: Benjamin Herrenschmidt @ 2008-07-22 22:05 UTC (permalink / raw)
  To: avorontsov
  Cc: Kumar Gala, linuxppc-dev list, Linux Kernel list, Alan Cox,
	David Brownell

On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
> On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > can someone look at the following compile failure in linus's tree.  I'm 
> > guessing part of this has to do with Alan's tty changes (and might  
> > already be addressed?).
> >
> > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > 'gpio_get_value'
> > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > 'gpio_set_value'
> 
> I think this patch should help:
> 
> [OF] of_gpio: should use new <linux/gpio.h> header
> http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> 
> David, can you please Ack it? See Benjamin's mail:
> http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> 

Hrm.. I though I had that one in my latest batch. In fact, I just
checked and it got merged.

Ben.



^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
  2008-07-22 22:05     ` Benjamin Herrenschmidt
@ 2008-07-22 22:26       ` Anton Vorontsov
  -1 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 22:26 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: David Brownell, linuxppc-dev list, Kumar Gala, Linux Kernel list,
	Alan Cox

On Wed, Jul 23, 2008 at 08:05:09AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
> > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > > can someone look at the following compile failure in linus's tree.  I'm 
> > > guessing part of this has to do with Alan's tty changes (and might  
> > > already be addressed?).
> > >
> > > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > > 'gpio_get_value'
> > > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > > 'gpio_set_value'
> > 
> > I think this patch should help:
> > 
> > [OF] of_gpio: should use new <linux/gpio.h> header
> > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> > 
> > David, can you please Ack it? See Benjamin's mail:
> > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> > 
> 
> Hrm.. I though I had that one in my latest batch. In fact, I just
> checked and it got merged.

Ah, great. So the issue should be fixed already... I just pulled the
Linus' tree, and it is there indeed.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

* Re: latest tree build failure -- cpm uart & gpio
@ 2008-07-22 22:26       ` Anton Vorontsov
  0 siblings, 0 replies; 13+ messages in thread
From: Anton Vorontsov @ 2008-07-22 22:26 UTC (permalink / raw)
  To: Benjamin Herrenschmidt
  Cc: Kumar Gala, linuxppc-dev list, Linux Kernel list, Alan Cox,
	David Brownell

On Wed, Jul 23, 2008 at 08:05:09AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2008-07-22 at 18:53 +0400, Anton Vorontsov wrote:
> > On Tue, Jul 22, 2008 at 08:54:16AM -0500, Kumar Gala wrote:
> > > can someone look at the following compile failure in linus's tree.  I'm 
> > > guessing part of this has to do with Alan's tty changes (and might  
> > > already be addressed?).
> > >
> > > include/asm-generic/gpio.h:131: error: implicit declaration of function 
> > > 'gpio_get_value'
> > > include/asm-generic/gpio.h:137: error: implicit declaration of function 
> > > 'gpio_set_value'
> > 
> > I think this patch should help:
> > 
> > [OF] of_gpio: should use new <linux/gpio.h> header
> > http://patchwork.ozlabs.org/linuxppc/patch?id=18750
> > 
> > David, can you please Ack it? See Benjamin's mail:
> > http://ozlabs.org/pipermail/linuxppc-dev/2008-July/060109.html
> > 
> 
> Hrm.. I though I had that one in my latest batch. In fact, I just
> checked and it got merged.

Ah, great. So the issue should be fixed already... I just pulled the
Linus' tree, and it is there indeed.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@gmail.com
irc://irc.freenode.net/bd2

^ permalink raw reply	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2008-07-22 22:26 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-07-22 13:54 latest tree build failure -- cpm uart & gpio Kumar Gala
2008-07-22 13:54 ` Kumar Gala
2008-07-22 13:52 ` Alan Cox
2008-07-22 14:53 ` Anton Vorontsov
2008-07-22 14:53   ` Anton Vorontsov
2008-07-22 19:33   ` David Brownell
2008-07-22 19:33     ` David Brownell
2008-07-22 20:48     ` Anton Vorontsov
2008-07-22 20:48       ` Anton Vorontsov
2008-07-22 22:05   ` Benjamin Herrenschmidt
2008-07-22 22:05     ` Benjamin Herrenschmidt
2008-07-22 22:26     ` Anton Vorontsov
2008-07-22 22:26       ` Anton Vorontsov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.