From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KLflt-0004q9-0X for mharc-grub-devel@gnu.org; Wed, 23 Jul 2008 10:56:53 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLflq-0004p1-HE for grub-devel@gnu.org; Wed, 23 Jul 2008 10:56:50 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLflo-0004oP-Ht for grub-devel@gnu.org; Wed, 23 Jul 2008 10:56:49 -0400 Received: from [199.232.76.173] (port=55182 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLflo-0004oH-Cp for grub-devel@gnu.org; Wed, 23 Jul 2008 10:56:48 -0400 Received: from gateway10.websitewelcome.com ([67.18.103.10]:50686) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KLfln-0006cB-Be for grub-devel@gnu.org; Wed, 23 Jul 2008 10:56:48 -0400 Received: (qmail 29050 invoked from network); 23 Jul 2008 15:02:55 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway10.websitewelcome.com with SMTP; 23 Jul 2008 15:02:55 -0000 Received: from c-67-185-142-228.hsd1.wa.comcast.net ([67.185.142.228]:50023 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1KLfli-0001w9-Gv; Wed, 23 Jul 2008 09:56:42 -0500 Date: Wed, 23 Jul 2008 07:56:03 -0700 From: Colin D Bennett To: The development of GRUB 2 Message-ID: <20080723075603.4e28906c@gibibit.com> In-Reply-To: <20080723073332.66008014@gibibit.com> References: <20080722084347.53863920@gibibit.com> <1216752511.5029.4.camel@dv> <20080722120632.7aa611ce@gibibit.com> <20080723073332.66008014@gibibit.com> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/c8WwfVgMh_AbFqfgFrqT1n="; protocol="application/pgp-signature"; micalg=PGP-SHA1 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Cc: bean123ch@gmail.com Subject: Re: [PATCH] File readahead buffering X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jul 2008 14:56:50 -0000 --Sig_/c8WwfVgMh_AbFqfgFrqT1n= Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Wed, 23 Jul 2008 07:33:32 -0700 Colin D Bennett wrote: > On Wed, 23 Jul 2008 10:05:36 +0800 > Bean wrote: >=20 > > On Wed, Jul 23, 2008 at 3:06 AM, Colin D Bennett > > wrote: > > > On Tue, 22 Jul 2008 14:48:31 -0400 > > > Pavel Roskin wrote: > > > > > >> On Tue, 2008-07-22 at 08:43 -0700, Colin D Bennett wrote: > > >> > This patch speeds up loading a TGA image on my test system from > > >> > 29 seconds to approximately 1 second. > > >> > > > >> > I noticed that on my 1 GHz test system running from an IDE > > >> > CompactFlash drive, loading a certain TGA image in GRUB takes > > >> > about 29 seconds. > > >> > > >> I'm sorry for straying from your point, but maybe we should drop > > >> TGA support. It was the first image format for GRUB to support, > > >> but now PNG is supported, and it should be better in all aspects. > > > > > > I agree that TGA is not, in general, a great choice for an image > > > format (unless it is faster to load a large background image -- a > > > 1024x768 RGB PNG file may take more time to decompress than a TGA > > > image would take to load -- although perhaps an uncompressed PNG > > > file would be comparable in speed to load). However, I have not > > > been able to load any PNG images that I have tried to use. > > > Something about the chunk type not being supported. > > > > >=20 > > Hi, > >=20 > > Please upload the png file that cause problem. > >=20 > > Also note that png use DEFLATE compression. I write a decoder in > > png, which may be a little slow. Perhaps I can import the decoder > > from zlib, if copyright allows. >=20 > Ok, after some more testing, I have found that if I create PNG images > with ImageMagick or The GIMP, they work. However, I have an image > that I was trying to use as a GRUB background which is from a MythTV > theme called Titivillus. The PNG file from the MythTV theme doesn't > load in GRUB. I get the message "error: png: block type fixed not > supported". Oops! After more testing, I have found PNG images that I saved in The GIMP which also refuse to load due to the "block type fixed not supported" error. One ZIP file [1] contains images that all fail to load in GRUB with that error, and the other [2] contains similar images that load just fine. [1] gibibit.com/upload/grub-png-bad.zip [2] gibibit.com/upload/grub-png-good.zip Regards, Colin --Sig_/c8WwfVgMh_AbFqfgFrqT1n= Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEARECAAYFAkiHRoYACgkQokx8fzcGbYc35wCeKPbfk3O11m8ACjDXCOzItBQl XX0AoJ9d5Y6jmLUrJJNCYBKurtY610+b =hqco -----END PGP SIGNATURE----- --Sig_/c8WwfVgMh_AbFqfgFrqT1n=--