From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLdPy-00016a-4D for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:26:06 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLdPw-00014o-En for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:26:05 -0400 Received: from [199.232.76.173] (port=53607 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLdPw-00014b-30 for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:26:04 -0400 Received: from mail.codesourcery.com ([65.74.133.4]:51762) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLdPv-0004ZG-KK for qemu-devel@nongnu.org; Wed, 23 Jul 2008 08:26:03 -0400 From: Paul Brook Subject: Re: [Qemu-devel] [PATCH] linux-user: Fix page_find_alloc for 32-bit use on 64-bit hosts Date: Wed, 23 Jul 2008 13:26:00 +0100 References: <487A658A.3060203@web.de> In-Reply-To: <487A658A.3060203@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807231326.00691.paul@codesourcery.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Jan Kiszka On Sunday 13 July 2008, Jan Kiszka wrote: > page_find_alloc, used e.g. for TB allocation, is not safe on 64-bit > hosts for 32-bit guests. Patch below fixes this by requesting new pages > only from the guest-reachable address range. I'm pretty sure this is wrong. The structures allocated by page_find_alloc do not need to be accessible by the guest. In fact it's better if they are outside the guest address space. Paul