From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [Xen-changelog] [xen-unstable] libxc: Clean up
	xc_map_foreign_ranges() interface to hide the
Date: Wed, 23 Jul 2008 17:02:49 +0100
Message-ID: <20080723160249.GQ4454@implementation.uk.xensource.com>
References: <200807231550.m6NFoicJ028399@xenbits.xensource.com>
	<20080723155940.GP4454@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <20080723155940.GP4454@implementation.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Samuel Thibault, le Wed 23 Jul 2008 16:59:41 +0100, a =E9crit :
> Xen patchbot-unstable, le Wed 23 Jul 2008 08:50:44 -0700, a =E9crit :
> > diff -r 351ce3b94e2d -r 7299346111fb tools/libxc/xc_private.h
> > --- a/tools/libxc/xc_private.h	Wed Jul 23 13:31:57 2008 +0100
> > +++ b/tools/libxc/xc_private.h	Wed Jul 23 16:39:46 2008 +0100
> > @@ -184,8 +184,9 @@ static inline int do_sysctl(int xc_handl
> >      return ret;
> >  }
> > =20
> > -int xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> > -                          privcmd_mmap_entry_t *entries, int nr);
> > +void *xc_map_foreign_ranges(int xc_handle, uint32_t dom,
> > +                            size_t size, int prot, size_t chunksize,
> > +                            privcmd_mmap_entry_t entries[], int nent=
ries);
>=20
> Mmm, why chunksize?  Shouldn't entries[] provide it, for a more powerfu=
l
> interface (each entry can have a different size)?

Also, the size argument is redundant.

Samuel