From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] V2, Convert bitfields in ASOC into full int width
Date: Wed, 23 Jul 2008 19:29:37 +0100 [thread overview]
Message-ID: <20080723182937.GA25367@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <20080723174302.14968.56684.stgit@terra>
On Wed, Jul 23, 2008 at 01:43:02PM -0400, Jon Smirl wrote:
> Convert bitfields in ASOC into full int width. This is a
> simple mechanical conversion. Two places in the DAPM code
> were fixed to properly use mask.
CHECK sound/soc/soc-core.c
include/sound/soc.h:71:4: error: Expected ; end of type declaration
include/sound/soc.h:71:4: error: got .
sound/soc/soc-core.c:295:6: error: undefined identifier 'SND_SOC_BIAS_PREPARE'
sound/soc/soc-core.c:308:6: error: undefined identifier 'SND_SOC_BIAS_STANDBY'
sound/soc/soc-core.c:369:7: error: undefined identifier 'SND_SOC_BIAS_STANDBY'
sound/soc/soc-core.c:441:28: error: undefined identifier 'SND_SOC_BIAS_ON'
sound/soc/soc-core.c:444:11: error: undefined identifier 'SND_SOC_BIAS_PREPARE'
sound/soc/soc-core.c:455:40: error: undefined identifier 'SND_SOC_BIAS_ON'
CC sound/soc/soc-core.o
In file included from sound/soc/soc-core.c:34:
include/sound/soc.h:71: error: expected identifier or ‘(’ before ‘.’ token
include/sound/soc.h:71: error: expected identifier or ‘(’ before ‘}’ token
The fix was trivial enough so I've made and applied it (and done some
brief testing of my own) - please be more careful in future.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2008-07-23 18:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 17:43 [PATCH] V2, Convert bitfields in ASOC into full int width Jon Smirl
2008-07-23 18:29 ` Mark Brown [this message]
2008-07-23 19:06 ` Jon Smirl
2008-07-23 20:33 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723182937.GA25367@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jonsmirl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.