From: Greg KH <greg@kroah.com>
To: Yinghai Lu <yhlu.kernel@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Arjan van de Ven <arjan@infradead.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: usb debug port early console v2
Date: Wed, 23 Jul 2008 16:21:42 -0700 [thread overview]
Message-ID: <20080723232142.GD30234@kroah.com> (raw)
In-Reply-To: <86802c440807231554g4fc4f981j5f9a8db9ab51fe93@mail.gmail.com>
On Wed, Jul 23, 2008 at 03:54:09PM -0700, Yinghai Lu wrote:
> On Wed, Jul 23, 2008 at 3:45 PM, Greg KH <greg@kroah.com> wrote:
> > On Wed, Jul 23, 2008 at 02:00:53PM -0700, Yinghai Lu wrote:
> >> --- linux-2.6.orig/drivers/usb/host/ehci.h
> >> +++ linux-2.6/drivers/usb/host/ehci.h
> >
> > I don't understand the issue of any of these #ifdefs here. Why are they
> > needed?
>
> In file included from arch/x86/kernel/early_printk.c:19:
> arch/x86/kernel/../../../drivers/usb/host/ehci.h:109: error: field
> 'iaa_watchdog' has incomplete type
Ah, so you are papering over the real problem here, right?
Why not just include the properly needed #includes either where you are
including this header file, or add the dependancies to the ehci.h file
itself (which is usually preferred.)
> > And shouldn't there be a separate config option for early printk through
> > the ehci debug port?
>
> under usb or processor?
Somewhere.
Also, usb patches should be cc:ed to the linux-usb mailing list. I'm
sure the EHCI authors would like to comment on this patch...
thanks,
greg k-h
next prev parent reply other threads:[~2008-07-23 23:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-23 19:52 [PATCH] x86: usb debug port early console Yinghai Lu
2008-07-23 20:12 ` Andrew Morton
2008-07-23 20:18 ` Yinghai Lu
2008-07-23 20:36 ` Andrew Morton
2008-07-24 2:56 ` Eric W. Biederman
2008-07-24 3:13 ` H. Peter Anvin
2008-07-23 21:00 ` [PATCH] x86: usb debug port early console v2 Yinghai Lu
2008-07-23 22:45 ` Greg KH
2008-07-23 22:54 ` Yinghai Lu
2008-07-23 23:21 ` Greg KH [this message]
2008-07-23 23:46 ` Yinghai Lu
2008-07-24 0:06 ` Greg KH
2008-07-24 0:39 ` [PATCH] x86: usb debug port early console v3 Yinghai Lu
2008-07-24 11:14 ` Ingo Molnar
2008-07-25 0:27 ` [PATCH] usb: move ehci reg def Yinghai Lu
2008-07-25 0:57 ` David Brownell
2008-07-25 2:14 ` Yinghai Lu
2008-07-26 14:18 ` Ingo Molnar
2008-07-28 15:40 ` Greg KH
2008-07-28 16:11 ` Ingo Molnar
2008-07-28 16:47 ` Greg KH
2008-07-28 18:47 ` David Brownell
2008-07-25 0:29 ` [PATCH] x86: usb debug port early console v4 Yinghai Lu
2008-07-26 13:48 ` Ingo Molnar
2008-07-26 15:38 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080723232142.GD30234@kroah.com \
--to=greg@kroah.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arjan@infradead.org \
--cc=ebiederm@xmission.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.