From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KLplS-00049F-W6 for mharc-grub-devel@gnu.org; Wed, 23 Jul 2008 21:37:07 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KLplR-000497-Kx for grub-devel@gnu.org; Wed, 23 Jul 2008 21:37:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KLplQ-00048n-AX for grub-devel@gnu.org; Wed, 23 Jul 2008 21:37:05 -0400 Received: from [199.232.76.173] (port=53568 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KLplQ-00048k-51 for grub-devel@gnu.org; Wed, 23 Jul 2008 21:37:04 -0400 Received: from spacedout.fries.net ([67.64.210.234]:39869) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KLplK-0001gN-43; Wed, 23 Jul 2008 21:36:58 -0400 Received: from SpacedOut.fries.net (david@localhost [127.0.0.1]) by SpacedOut.fries.net (8.13.8/8.13.8/Debian-3) with ESMTP id m6O1atEd016465 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 23 Jul 2008 20:36:55 -0500 Received: (from david@localhost) by SpacedOut.fries.net (8.13.8/8.13.8/Submit) id m6O1a8hl016414; Wed, 23 Jul 2008 20:36:08 -0500 Date: Wed, 23 Jul 2008 20:36:07 -0500 From: David Fries To: The development of GRUB 2 Message-ID: <20080724013607.GA5621@spacedout.fries.net> References: <20080724005259.GA16237@spacedout.fries.net> <1216862038.30436.8.camel@dv> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1216862038.30436.8.camel@dv> User-Agent: Mutt/1.5.4i X-Greylist: Sender is SPF-compliant, not delayed by milter-greylist-3.0 (SpacedOut.fries.net [127.0.0.1]); Wed, 23 Jul 2008 20:36:56 -0500 (CDT) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Pavel Roskin Subject: Re: [PATCH] hold shift or control to disable timeout even timeout=0 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2008 01:37:05 -0000 On Wed, Jul 23, 2008 at 09:13:58PM -0400, Pavel Roskin wrote: > On Wed, 2008-07-23 at 19:52 -0500, David Fries wrote: > > > This calls the getshiftflags BIOS int 16h function 2 in startup.S, to > > find out the status of the shift and control keys (among others). The > > required header and source files were modified to expose > > grub_getshiftflags. menu.c checks grub_getshiftflags and will disable > > the timeout. > > Cannot we avoid adding code to core.img that it not called from > core.img? Just because it's written in assembly it doesn't mean it > should be in the in the core. I could make the argument that it is ten assmebly instructions, but I think the stronger case is the other two keyboard reading routines are right there in the same file. I suppose the grub_checkkey and the new grub_getshiftflags could both be moved out of core.img, but where would they go and how would they get assigned to the grub_term structure? > Sure, we are better off now that we are using lzma, but it we start > adding stuff mindlessly, core.img can again grow too large for some > setups. > > -- > Regards, > Pavel Roskin > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > http://lists.gnu.org/mailman/listinfo/grub-devel -- David Fries http://fries.net/~david/ (PGP encryption key available)