Re: ftrace: eh?

[Ingo Molnar <mingo@elte.hu>]

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> kernel/trace/trace.c:s_next():
>
> 	if (last_ent && !ent)
> 		seq_puts(m, "\n\nvim:ft=help\n");
>
> eh?

uhm, yes, that was me, years ago when i wrote the original version of 
the latency tracer. If you look at such traces via vim then portions of 
the trace will be color highlighted automatically with that tag in 
place.

Thanks for the reminder, i've removed it via the patch below.

	Ingo

------------>
commit 1986b0cb1671ea39178b4e2b00461109728fc935
Author: Ingo Molnar <mingo@elte.hu>
Date:   Thu Jul 24 08:10:02 2008 +0200

    ftrace: remove latency-tracer leftover
    
    remove the :vim=ft=help tag from trace files.
    
    I used them years ago to syntax-highlight traces and forgot about this hack.
    
    Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 kernel/trace/trace.c |    3 ---
 1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
index 868e121..fc20e09 100644
--- a/kernel/trace/trace.c
+++ b/kernel/trace/trace.c
@@ -1203,9 +1203,6 @@ static void *s_next(struct seq_file *m, void *v, loff_t *pos)
 
 	iter->pos = *pos;
 
-	if (last_ent && !ent)
-		seq_puts(m, "\n\nvim:ft=help\n");
-
 	return ent;
 }